Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard in block navigation editable text not working correctly #22488

Closed
talldan opened this issue May 20, 2020 · 1 comment
Closed

Keyboard in block navigation editable text not working correctly #22488

talldan opened this issue May 20, 2020 · 1 comment
Assignees
Labels
[Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Type] Bug An existing feature does not function as intended

Comments

@talldan
Copy link
Contributor

talldan commented May 20, 2020

Describe the bug
A combination of #18014 and #22210 being worked on in parallel seems to have resulted in some issues keyboard navigating around block navigation on the experimental Navigation page:

  • The contenteditable (RichText) used in block navigation isn't managed as part of the roving tab index system
  • Horizontal arrow keys aren't usable for moving the caret within the contenteditable

To reproduce
Steps to reproduce the behavior:

  1. Enable and visit the experimental navigation page (wp-admin/admin.php?page=gutenberg-navigation)
  2. Add a navigation block with several links
  3. Tab into block navigation and use arrow keys to move to a navigation link's editable text
  4. Try to use horizontal arrow keys while the caret is within some text
  5. Observe that focus is moved out of the contenteditable
  6. Arrow key back to a contenteditable
  7. Try using tab or shift+tab to tab out of block navigation
  8. Observe that tab often navigates to another contenteditable.

Expected behavior

  • Arrow keys can be used to edit text, only moving to another element when at boundaries of text.
  • Block navigation has a single tab stop.
@talldan talldan added [Type] Bug An existing feature does not function as intended [Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Feature] Navigation Screen labels May 20, 2020
@talldan talldan self-assigned this May 20, 2020
@talldan
Copy link
Contributor Author

talldan commented Aug 21, 2020

This should have been closed by #22885 and also that the input is not longer active in List View.

@talldan talldan closed this as completed Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

1 participant