Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for separate tests config for wp-env #22514

Closed
talldan opened this issue May 21, 2020 · 0 comments · Fixed by #22568
Closed

Allow for separate tests config for wp-env #22514

talldan opened this issue May 21, 2020 · 0 comments · Fixed by #22568
Labels
[Tool] Env /packages/env [Type] Enhancement A suggestion for improvement.

Comments

@talldan
Copy link
Contributor

talldan commented May 21, 2020

Is your feature request related to a problem? Please describe.
#20280 enabled using wp-env for e2e tests in travis, but unearthed a few minor issues.

One of which is that SCRIPT_DEBUG is historically set to false for e2e tests and true for a dev environment. Currently wp-env only supports a single config for both environments. The workaround for travis was to output a .wp-env.override file:
https://github.com/WordPress/gutenberg/blob/master/.travis.yml#L56

This isn't very maintainable because it overrides all settings.

Describe the solution you'd like
A separate configuration for tests.

Describe alternatives you've considered
Command line options for overriding individual settings, e.g.

wp-env start --override-config SCRIPT_DEBUG=false
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Tool] Env /packages/env [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant