Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Library: Refactor Embed block to use block.json and block variations #22660

Closed
gziolo opened this issue May 27, 2020 · 0 comments · Fixed by #24090
Closed

Block Library: Refactor Embed block to use block.json and block variations #22660

gziolo opened this issue May 27, 2020 · 0 comments · Fixed by #24090
Assignees
@ntsekouras
Labels
[Block] Embed Affects the Embed Block [Priority] High Used to indicate top priority items that need quick attention REST API Interaction Related to REST API [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@gziolo
Copy link
Member

gziolo commented May 27, 2020 •
edited
Loading

Description

Part of #16209.

Follow-up for #22491 where all blocks but Embed were refactored to be registered on the server with block.json metadata files.

Embed block is really a collection of multiple variations of the same block so ideally it should be converted to one block containing a set of block variations. Similar to what @mcsf did for Social Icon block: #19887.

All that makes it hard to move its settings to a single block.json and register in on the server to be exposed in the REST API endpoint with block definitions.
@gziolo gziolo added [Type] Task Issues or PRs that have been broken down into an individual action to take [Block] Embed Affects the Embed Block labels May 27, 2020
@gziolo gziolo mentioned this issue May 27, 2020
Merged
4 tasks
@gziolo gziolo added the REST API Interaction Related to REST API label Jul 8, 2020
@gziolo gziolo changed the title Block Library: Refactor Embed blocks to use block.json Block Library: Refactor Embed blocks to use block.json and block variations Jul 8, 2020
@gziolo gziolo changed the title Block Library: Refactor Embed blocks to use block.json and block variations Block Library: Refactor Embed block to use block.json and block variations Jul 8, 2020
@gziolo gziolo mentioned this issue Jul 8, 2020
Closed
@gziolo gziolo added the [Priority] High Used to indicate top priority items that need quick attention label Jul 8, 2020
@gziolo gziolo mentioned this issue Jul 8, 2020
Closed
14 tasks
@ntsekouras ntsekouras self-assigned this Jul 16, 2020
This was referenced Jul 20, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ntsekouras ntsekouras

Labels
[Block] Embed Affects the Embed Block [Priority] High Used to indicate top priority items that need quick attention REST API Interaction Related to REST API [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor embed block to single block with block variations WordPress/gutenberg
3 participants
@bph @gziolo @ntsekouras