Iterate on 'add navigation link'

[karmatosed]

Now the links are surfaced with labels the following appears for the navigation block:

I know there was discussion about having the block title changed, I do think that this is a rather long title and also because of the styling looks almost like a navigation link itself.

There are a few considerations to discuss:

• Should this have a different styling to stand out more?
• Could the title be shortened?

Along with this, it doesn't change based on background changed so you can get the following:

[shaunandrews]

I question the need for a label to accompany the insert button — especially when/if this allows you to insert more than just a link.

--

That said, if we do think the label is necessary, perhaps we can both shorten in and include it within the button element.

Excuse my text-based mockup, but something like this: [ + Add link ]

[draganescu]

Initially the text was not there, it was added only when the inserter adds one kind of block directly on click, to minimize the surprise. The child of Navigation could be just called Link.

So we could do three things here:

• Rename Navigation Link to Link
• Fix the dark style to include a correct display of the inserter along with the text

I don't think we want the inserter of the Navigation block to be different than the rest of the Editor and incorporating text into the button is a big departure.

[shaunandrews]

We should rename "Navigation Link" to just "Link."

--

Along with that, I think adding the label inside the button shape is an interesting solution. It retains the inserter's visual appearance and tightly couples the label to the button.

For the dark style variation, the button would reverse it's colors:

--

I'd imagine this would work across other blocks which restrict their InnerBlocks, like the Buttons block:

I'd love to know what @pablohoneyhoney and @mtias think about this suggestion.

[mtias]

I question the need for a label to accompany the insert button — especially when/if this allows you to insert more than just a link.

This is a standard behaviour that needs to only happen if there's a single block to be inserted in a given area.

It inherits the name of the block, so any change in wording needs to happen in the block itself.

My main worry with the treatment above is that it looks like a new button style (icon + text).

[pablohoneyhoney]

I think at the moment it does look too much as the actual output.
One solution could be to avoid the +, and only say Add Link or Add Button

Curious is this new element will have any other application in other contexts, the sidebar comes to mind, or generally FSE interfaces. If it has, then it's worth trying.

[shaunandrews]

This is a standard behaviour that needs to only happen if there's a single block to be inserted in a given area.

Sure, I get that.

It inherits the name of the block, so any change in wording needs to happen in the block itself.

Yup, sorry if I was unclear — I'm suggested we rename the "Navigation Link" block to just "Link".

My main worry with the treatment above is that it looks like a new button style (icon + text).

Sure, and it is a new style, and I am hesitant to introduce it. But, the alternative of having the label outside the button shape (as we do now) is that the label could be confused for content and not UI.

--

One solution could be to avoid the +, and only say Add Link or Add Button

Here's what that could look like:

Curious is this new element will have any other application in other contexts, the sidebar comes to mind, or generally FSE interfaces.

Hmmm, that's a good question. One thing that comes to mind is the site-level sidebar that I've been exploring:

[mtias]

Yup, sorry if I was unclear — I'm suggested we rename the "Navigation Link" block to just "Link".

Yes, agreed with this.

But, the alternative of having the label outside the button shape (as we do now) is that the label could be confused for content and not UI.

I think this is a bit specific to the navigation link case. How does it look for buttons? I think perhaps we should just revert to the + on its own.

Perhaps it's worth trying adding just the block type icon next to the + (within the dark container)?

[draganescu]

closed by #23163 and #23165