Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Advanced link to Options modul. #22839

Closed
paaljoachim opened this issue Jun 2, 2020 · 5 comments
Closed

Adding Advanced link to Options modul. #22839

paaljoachim opened this issue Jun 2, 2020 · 5 comments
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) Needs Design Feedback Needs general design feedback.

Comments

@paaljoachim
Copy link
Contributor

paaljoachim commented Jun 2, 2020

Is your feature request related to a problem? Please describe.
There are a few issues where many are asking for the No Follow link option.
Such as:

Add easy way to modify links and add toggle options.
#17556

Add nofollow option for links
#13542

Make link selection consistent
#17293

and there are probably other associated issues.

Describe the solution you'd like

Today we have this link dialog:
Screen Shot 2020-06-02 at 21 39 25

I am wondering if we should add an Advanced Link option to the options modal similar to this mockup:
Options-Panel-Add-Advanced-links

Clicking the Advanced links will then change the Link modul and add additional options to it like the No follow option.

Describe alternatives you've considered
Editorskit plugin already has additional link options included in it's link modul so the user can always choose to use that.

@paaljoachim paaljoachim added [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) Needs Design Feedback Needs general design feedback. labels Jun 2, 2020
@richtabor
Copy link
Member

I don't personally think it warrants a separate display option.

@paaljoachim
Copy link
Contributor Author

Hey Rich @richtabor
I am trying to look at different ways we can handle the additional link attributes. This was one way I thought of. I am hoping that it can inspire to figuring out even better ways. Suggest a way that will not work and then hope to create discussions in finding a way that does..:)

@richtabor
Copy link
Member

richtabor commented Jun 4, 2020

What about a "more" trigger that when toggled on, reveals any additional controls?

Here's a super quick Figma prototype →

Frame 2

@paaljoachim
Copy link
Contributor Author

Looks good to me! That would work even better.
Let's close this issue and open a new issue suggesting it.
I'll close here, and if that's alright then you can open a new issue adding the Figma image.

@paaljoachim
Copy link
Contributor Author

Thanks Rich.
I went ahead and opened this issue: Link Control: Add more controls.
#23011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) Needs Design Feedback Needs general design feedback.
Projects
None yet
Development

No branches or pull requests

2 participants