Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link control: No way to see which word will become a link. #23112

Closed
paaljoachim opened this issue Jun 12, 2020 · 4 comments
Closed

Link control: No way to see which word will become a link. #23112

paaljoachim opened this issue Jun 12, 2020 · 4 comments
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Type] Enhancement A suggestion for improvement.

Comments

@paaljoachim
Copy link
Contributor

paaljoachim commented Jun 12, 2020

Describe the bug... well not really a bug.... perhaps just a missing enhancement.

Opening up the link control to add a link the word or sentence marked to become a link becomes non selected/non marked. Like so...

Screen Shot 2020-06-12 at 11 32 55

From the above I have no idea to know which word will receive a link.

--

Example solution is to mark the selected future link. Black underline, blue outline etc.
Here-marked-by-blue-outline

Yes. I do! I can see which word will become a link! Yay that makes me happy!


To reproduce
Steps to reproduce the behavior:

  1. Write some words.
  2. Select one of the words to become a link.
  3. Open the link control.
  4. Notice that one can not see which word will become a link.

Expected behavior
I expect to be able to see which word I selected to become a link when the link control is active.

Chrome
WP 5.4.2
Local test site using Twenty Twenty
Gutenberg plugin 8.3.0

@paaljoachim paaljoachim added [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Type] Enhancement A suggestion for improvement. labels Jun 12, 2020
@getdave
Copy link
Contributor

getdave commented Jun 15, 2020

@paaljoachim I believe that originally the popover UI used to have an arrow which pointed toward the element that triggered it.

See screencapture in #17846 (comment) for example of this.

Perhaps this got removed in G2 or perhaps it was never implemented for the RichText version of the Link Control?

@paaljoachim
Copy link
Contributor Author

I asked Joen. He told me that @ellatrix can fix this by using iframe.

He mentioned that the text becomes cleared when the focus is on the popover. As one is not able to have a selection in the input field in one place while the focus is in the input field in another place. It is possible with an iframe.

@paaljoachim
Copy link
Contributor Author

Here is a new very interesting Link control feature being designed by @shaunandrews
#23375

@ellatrix
Copy link
Member

Duplicate of #6156.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants