Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pullquote: when we change the main colour then the text of Pullquote is not visible #24440

Closed
kmadhak opened this issue Aug 7, 2020 · 1 comment · Fixed by #24600
Closed

Pullquote: when we change the main colour then the text of Pullquote is not visible #24440

kmadhak opened this issue Aug 7, 2020 · 1 comment · Fixed by #24600
Assignees
@ntsekouras
Labels
[Block] Pullquote Affects the Pullquote Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@kmadhak
Copy link

kmadhak commented Aug 7, 2020 •
edited
Loading

Describe the bug
in Pullquote when we select the solid colour style and we set the main colour as black then text colour automatically set to cream colour and we unset the main colour then the text colour is not getting changed to default colour, because of that we are not able to view the text of Pullquote.

To reproduce
Steps to reproduce the behaviour:

  1. Go to 'Editor'
  2. Add new page
  3. Click on 'add block'
  4. Select the block 'Pullquote'
  5. Select the Style 'Solid color'
    6 Set the main colour 'black'
  6. Unset the main colour
  7. See error

Expected behaviour
when we unset the main colour then the text colour should be the default colour so we can view the text of Pullquote.

Screenshots
https://prnt.sc/tvn4la
https://prnt.sc/tvn53e

Video
for more detail please view the attached video
https://www.loom.com/share/165a6ddfde9b4322be055068a57d6549

Editor version (please complete the following information):

  • WordPress version: 5.5-beta1
  • default

Desktop (please complete the following information):

  • OS: Windows
  • Browser chrome
  • Version 84.0.4147.105 (Official Build) (64-bit)
@annezazu annezazu added [Block] Pullquote Affects the Pullquote Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Bug An existing feature does not function as intended labels Aug 14, 2020
@ntsekouras ntsekouras self-assigned this Aug 17, 2020
@ntsekouras ntsekouras mentioned this issue Aug 17, 2020
Merged
6 tasks
@ntsekouras
Copy link
Contributor

Thanks for reporting this @kmadhak!

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ntsekouras ntsekouras

Labels
[Block] Pullquote Affects the Pullquote Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Pullquote text color after unsetting main color WordPress/gutenberg
3 participants
@ntsekouras @annezazu @kmadhak