Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSS block: how to have more than 10 items? #24859

Closed
ghost opened this issue Aug 27, 2020 · 4 comments · Fixed by #39819
Closed

RSS block: how to have more than 10 items? #24859

ghost opened this issue Aug 27, 2020 · 4 comments · Fixed by #39819
Assignees
Labels
[Block] RSS Affects the RSS Block - used to display entries from an RSS/Atom feed [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@ghost
Copy link

ghost commented Aug 27, 2020

I can not have more than 10 items with RSS block.

Try to remove the limit of 10 items.

@aristath aristath added [Block] RSS Affects the RSS Block - used to display entries from an RSS/Atom feed [Type] Help Request Help with setup, implementation, or "How do I?" questions. labels Aug 27, 2020
@aristath
Copy link
Member

The 10 limit was part of the initial implementation in #7966, but as far as I can see there was no discussion around the number, it was simply deemed reasonable - and in most cases I'd say it probably is.
I can see however why some would want a larger number... Perhaps we could make it easy to modify.

@ghost
Copy link
Author

ghost commented Aug 27, 2020

Maybe to show job advertisements

@sabernhardt
Copy link
Contributor

Does the RangeControl require a max value for the number field? If so, it probably could be as high as 100 (same range as the number of words in excerpts).

As it is now:
When typing a larger number in the input and clicking Publish (or Update) immediately after, I was able to get away with exceeding the maximum. However, when I clicked on that block again, it corrected the number to the maximum value of 10.

@skorasaurus skorasaurus added [Type] Enhancement A suggestion for improvement. and removed [Type] Help Request Help with setup, implementation, or "How do I?" questions. labels Feb 1, 2021
@Mamaduka
Copy link
Member

The classic RSS widget limit is 20, and it will fall back to default 10. Should we increase max to 20 as well?

I'm not sure if there's a historical reason for these limits.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] RSS Affects the RSS Block - used to display entries from an RSS/Atom feed [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants