Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widget screen: Add Drag & Drop of widgets between collapsed widget areas #25243

Closed
paaljoachim opened this issue Sep 11, 2020 · 3 comments · Fixed by #25992
Closed

Widget screen: Add Drag & Drop of widgets between collapsed widget areas #25243

paaljoachim opened this issue Sep 11, 2020 · 3 comments · Fixed by #25992
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. [Type] Bug An existing feature does not function as intended

Comments

@paaljoachim
Copy link
Contributor

paaljoachim commented Sep 11, 2020 •
edited
Loading

It looks like drag & drop is not at the moment working.

It would be helpful to be able to drag and drop widget/blocks between one widget area and another.

Example from the old Widget Screen:

Drag-drop-old-Widget-Screen
@paaljoachim paaljoachim added [Feature] Drag and Drop Drag and drop functionality when working with blocks [Feature] Widgets Screen The block-based screen that replaced widgets.php. labels Sep 11, 2020
@paaljoachim paaljoachim mentioned this issue Sep 11, 2020
Closed
@youknowriad
Copy link
Contributor

Drag and drop between widget areas is already available. The issue now is that the areas need to be opened.

@draganescu draganescu added [Type] Bug An existing feature does not function as intended and removed [Feature] Drag and Drop Drag and drop functionality when working with blocks labels Oct 1, 2020
@manooweb
Copy link
Contributor

manooweb commented Oct 2, 2020

Drag and drop between widget areas is already available. The issue now is that the areas need to be opened.

Do you mean, because the second widget area isn't opened we can't drag and drop form one to the other ?

What I noticed

  1. when a widget area is opened and not empty I can move a widget from another widget area 👍
  2. when a widget area is closed I can't move a widget from another widget area. It needs to be opened automatically as in the legacy widget page to be able to drop the widget.
  3. when a widget area is empty, it is always closed, so we can't move a widget from another widget area to an empty widget area. See the second point

@paaljoachim paaljoachim mentioned this issue Oct 6, 2020
Closed
@draganescu draganescu changed the title Widget screen: Add Drag & Drop of widgets between widget areas Widget screen: Add Drag & Drop of widgets between collapsed widget areas Oct 8, 2020
@adamziel adamziel mentioned this issue Oct 9, 2020
Merged
5 tasks
@paaljoachim
Copy link
Contributor Author

I believe we can go ahead and close this issue. As the PR for dragging & dropping widgets between widget areas have been merged.

@talldan talldan linked a pull request Oct 19, 2020 that will close this issue
Uncollapse widget area when block is dragged over #25992
Merged
5 tasks
@talldan talldan closed this as completed Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Uncollapse widget area when block is dragged over WordPress/gutenberg
5 participants
@draganescu @youknowriad @talldan @manooweb @paaljoachim