-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site Editor: Extend the NavigationItem Components to Support Page and Template Previews #25261
Comments
Isn't this something that's the consumer's concern? We just need to make the component extensible so the consumer can show the preview. Which is kinda possible right now. We can add mouseenter and mouseleave event handlers on the NavigationItem. I don't think we should add this to Navigation package. That would make it coupled with the block editor. |
Once we have the core implementations in place, then we can create a Navigation component in |
@david-szabo97 agree! Although, there could be a need of a standard item component with a preview panel.
We probably not need to add the hover handlers to |
@david-szabo97 I think there has been a regression on this, and previews are not visible anymore. |
Closing this, works fine on |
The current page/template selector supports template (and theme) previews:
gutenberg/packages/edit-site/src/components/header/index.js
Lines 108 to 127 in 668a710
We should replicate the same functionality in the new site editor navigation, by extending
NavigationItem
to support previews that show up on mouse over.Depends on #25244.
(Source)
The text was updated successfully, but these errors were encountered: