Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widgets with custom UI go missing #25836

Closed
simison opened this issue Oct 5, 2020 · 5 comments
Closed

Widgets with custom UI go missing #25836

simison opened this issue Oct 5, 2020 · 5 comments
Labels
[Block] Legacy Widget Affects the Legacy Widget Block - used for displaying Classic Widgets [Feature] Widgets Screen The block-based screen that replaced widgets.php. [Package] Edit Widgets /packages/edit-widgets [Type] Plugin Interoperability Incompatibilities between a specific plugin and the block editor. Close with workaround notes.

Comments

@simison
Copy link
Member

simison commented Oct 5, 2020

Describe the bug
Jetpack plugin has a "widget visibility" feature which extends capabilities of all the regular widgets.

When custom visibility has been set to a widget in the classic screen, the whole widget goes missing on the new screen. It still appears on the frontend of the site just fine.

To reproduce
Steps to reproduce the behavior:

  1. Install Jetpack, and connect it to WordPress.com

  2. Go to /wp-admin/admin.php?page=jetpack#/writing and enable widget visibility:

    Screenshot 2020-10-05 at 16 40 55
  3. Go to legacy widget screen (or customizer), and add some visibility setting to any core-widget from "visibility" button:

    Screenshot 2020-10-05 at 15 31 01
  4. Enable new Widgets screen and have a look — the widget is gone:

    Screenshot 2020-10-05 at 15 41 25
  5. Confirm that widget still appears on the site:

    Screenshot 2020-10-05 at 15 41 25

Expected behavior

  • I expected all the custom UI to go missing, no problem there. It needs to be re-implemented.
  • I did expect the widget itself to appear on the list in the name of backward compatibility. If it cannot be shown as functional, I would've expected it to show up in the list with some "incompatible" indication.
  • In other words, I expected all widgets that appear at the site, be also visible in some way or the other in the widgets screen.

Editor version (please complete the following information):

  • WordPress version 5.5.1
  • Gutenberg plugin 9.1.0
@simison simison added the [Feature] Widgets Screen The block-based screen that replaced widgets.php. label Oct 5, 2020
@adamziel adamziel added [Package] Edit Widgets /packages/edit-widgets [Block] Legacy Widget Affects the Legacy Widget Block - used for displaying Classic Widgets labels Oct 5, 2020
@adamziel
Copy link
Contributor

adamziel commented Oct 5, 2020

Related: #18068 #25758 - I'm not sure if it's would be even possible to extend the block editor with visibility UI (or any other similar UI) ATM.

@simison
Copy link
Member Author

simison commented Oct 5, 2020

I think the UI would appear at block toolbar or similar like you'd extend any old block in the page editor? That's secondary though. I think the backward compatibility issue at backend seems more important.

@talldan talldan added the [Type] Plugin Interoperability Incompatibilities between a specific plugin and the block editor. Close with workaround notes. label Oct 7, 2020
@noisysocks
Copy link
Member

Hey @simison, I wasn't able to reproduce this with the latest Gutenberg master.

Here's a GIF demonstrating my testing steps:

jetpack

Let me know if I've made a mistake or if you're still encountering this and we can re-open.

@draganescu
Copy link
Contributor

Normally all the form options should appear. The bug here is the widget is completely gone, but in general a legacy widget shown by the Legacy Widget block in the Widget editor should show the exact same edit form it did in the old editor (screen).

To update the UI and use block extensibility or editor extensibility options, the widget has to be "migrated" (reimplemented) as a block and the legacy widget will not be used automatically.

@adamziel
Copy link
Contributor

adamziel commented Oct 9, 2020

I managed to reproduce the problem on Gutenberg 9.1.1:

Zrzut ekranu 2020-10-9 o 16 12 32

Zrzut ekranu 2020-10-9 o 16 12 36

That being said, things are back to normal immediately after switching back to master:

Zrzut ekranu 2020-10-9 o 16 14 16

It seems like one of the PRs we merged in the meantime fixed the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Legacy Widget Affects the Legacy Widget Block - used for displaying Classic Widgets [Feature] Widgets Screen The block-based screen that replaced widgets.php. [Package] Edit Widgets /packages/edit-widgets [Type] Plugin Interoperability Incompatibilities between a specific plugin and the block editor. Close with workaround notes.
Projects
None yet
Development

No branches or pull requests

5 participants