Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems keyboarding through the areas #25880

Closed
mapk opened this issue Oct 6, 2020 · 4 comments
Closed

Problems keyboarding through the areas #25880

mapk opened this issue Oct 6, 2020 · 4 comments
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Accessibility Feedback Need input from accessibility [Type] Bug An existing feature does not function as intended

Comments

@mapk
Copy link
Contributor

mapk commented Oct 6, 2020

Problem

It's difficult to tell when tabbing jumps between areas, or into areas. And there's definitely an instance where tabbing twice still only highlights the area's label (accordion heading). But only one of those when clicking Enter actually open/closes the area.

Example of problem

keyboarding

Solution

I'm not sure here. But I should be able to jump across areas without having to go into Select mode, which is weird on this screen because it doesn't exist in the topbar like it does in the post editor.

Notice no "Select Mode" ability in the topbar, but I can still enter into Select mode by using ESC.

Screen Shot 2020-10-06 at 3 49 04 PM

@mapk mapk added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Feature] Widgets Screen The block-based screen that replaced widgets.php. Needs Accessibility Feedback Need input from accessibility labels Oct 6, 2020
@enriquesanchez
Copy link
Contributor

I agree that this:

Screen Shot 2020-10-07 at 18 09 21

and this:

Screen Shot 2020-10-07 at 18 09 29

feel like I'm in the same "state". Whether we call that Select mode or not, I don't see any distinction besides the floating label.

Removing the additional TAB should help a lot with kbd navigation and orientation.

Can we instead directly move to expand the widget area after hiting Enter?

@enriquesanchez
Copy link
Contributor

enriquesanchez commented Oct 8, 2020

Here's another example of the confusion that can be caused by the multiple TABs needed to expand a widget area:

2020-10-07 18-28-02 2020-10-08 09_15_23

When the accordion heading is selected, I kept pressing Enter and nothing happened. I also tried with Space and that would scroll me down the page.

It wasn't until I pressed Tab again that I was able to expand the accordion.

@draganescu
Copy link
Contributor

Related #25965

@draganescu draganescu changed the title Widget Editor: More problems keyboarding through the areas Problems keyboarding through the areas Feb 18, 2021
@tellthemachines
Copy link
Contributor

This is now fixed: when focusing on widget area headers, they can be immediately opened on pressing Enter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Accessibility Feedback Need input from accessibility [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants