Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Widgets Screen] Cover Block stretches across widget area if height left unspecified #26181

Closed
annezazu opened this issue Oct 16, 2020 · 5 comments
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Feature] Widgets Screen The block-based screen that replaced widgets.php. Needs Testing Needs further testing to be confirmed.

Comments

@annezazu
Copy link
Contributor

Describe the bug

If you add a cover block to the new Widgets Screen without specifying height, it stretches in a fairly dramatic way on the front end of the site.

To reproduce
Steps to reproduce the behavior:

  1. Install Gutenberg and activate.
  2. Go to Appearance > Widgets.
  3. Add a Cover Block.
  4. View on the front end of the site to see it overtake the widget area.

Expected behavior

I expect the Cover Block to not take up so much space vertically.

Screenshots

Video here: https://cloudup.com/cFRDApT8p2Z

Editor version (please complete the following information):

  • WordPress version: 5.5.1
  • Does the website has Gutenberg plugin installed, or is it using the block editor that comes by default? Gutenberg Plugin
  • If the Gutenberg plugin is installed, which version is it? 9.1.1

Desktop (please complete the following information):

  • OS: MacOS
  • Browser: Chrome
  • Version: 86.0.4240.75
@annezazu annezazu added [Type] Bug An existing feature does not function as intended [Feature] Widgets Screen The block-based screen that replaced widgets.php. [Block] Cover Affects the Cover Block - used to display content laid over a background image labels Oct 16, 2020
@talldan
Copy link
Contributor

talldan commented Oct 16, 2020

I wasn't able to reproduce. Just for comparison:

@annezazu result:
Screenshot 2020-10-16 at 2 24 34 pm

My result:
Screenshot 2020-10-16 at 2 23 46 pm

I tried a few different things, but wasn't able to get the cover to overlap.

@talldan talldan added the Needs Testing Needs further testing to be confirmed. label Oct 16, 2020
@annezazu
Copy link
Contributor Author

@talldan I found the key variable! Add more content to footer #2 that stretches down and you'll find the cover block fills in the space. Here's a video to demonstrate as this is a bit hard to explain: https://cloudup.com/csMl6wf_6pT

@annezazu annezazu removed the Needs Testing Needs further testing to be confirmed. label Oct 16, 2020
@talldan
Copy link
Contributor

talldan commented Jun 10, 2021

I still can't reproduce this, I have plenty of content in the second footer and the cover block still looks the same:
Screenshot 2021-06-10 at 3 58 49 pm

@talldan talldan added Needs Testing Needs further testing to be confirmed. and removed [Type] Bug An existing feature does not function as intended labels Jun 10, 2021
@Mamaduka
Copy link
Member

I followed the steps and also not able to reproduce the issue.

Cover block has the default min-height defined in block styles. So not specifying min-height shouldn't be an issue.

@draganescu
Copy link
Contributor

I also could not reproduce this. It may be one of the incipient problems which have been solved in the meantime. Given the date of the issue and the number of attempts to repro I'll close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Feature] Widgets Screen The block-based screen that replaced widgets.php. Needs Testing Needs further testing to be confirmed.
Projects
None yet
Development

No branches or pull requests

4 participants