-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search for posts when adding links is potentially VERY slow #26358
Labels
[Feature] Link Editing
Link components (LinkControl, URLInput) and integrations (RichText link formatting)
[Status] In Progress
Tracking issues with work in progress
[Type] Bug
An existing feature does not function as intended
Comments
talldan
added
[Feature] Link Editing
Link components (LinkControl, URLInput) and integrations (RichText link formatting)
[Type] Bug
An existing feature does not function as intended
labels
Oct 22, 2020
I marked #26374 as a duplicate. We probably want to 'debounce' when a user is typing, so the requests are only made when there's a reasonable pause. That should have already been the case, but maybe it became broken for some reason. |
I run into this as well recently. It used to work well. |
github-actions
bot
added
the
[Status] In Progress
Tracking issues with work in progress
label
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Link Editing
Link components (LinkControl, URLInput) and integrations (RichText link formatting)
[Status] In Progress
Tracking issues with work in progress
[Type] Bug
An existing feature does not function as intended
Describe the bug
When you want to add a link to your paragraph block, you will open a small modal where you can search for a post on your site. This searchbox adds a ajax query for every onKeyUp resulting in as many queries as the amount of letters in your search. Since the result will not show until all are finished, this can take a very long time(Especially when there are a lot of posts on your site. 45.000 posts resulted in a search that took well over 30 seconds)
To reproduce
Steps to reproduce the behavior:
Expected behavior
ajax calls that are no longer valid should be aborted when a new one is being called.
Editor version (please complete the following information):
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: