Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic blocks no longer rendering with their wrapper classnames on the frontend #26441

Closed
talldan opened this issue Oct 26, 2020 · 5 comments
Closed
Assignees
Labels
[Priority] High Used to indicate top priority items that need quick attention [Type] Regression Related to a regression in the latest release

Comments

@talldan
Copy link
Contributor

talldan commented Oct 26, 2020

Describe the bug
Since #26356 was merged, dynamic blocks no longer render with the wp-block-blockname class on their wrappers

To reproduce
Steps to reproduce the behavior:

  1. Add a dynamic block (like Search)
  2. Preview the post
  3. Inspect the block and notice that the wp-block-search classname is missing.
  4. Some blocks may not be styled correctly due to the missing classname

Expected behavior
The wp-block-search classname is retained.

Screenshots

Search block with the wrapper class

Screenshot 2020-10-26 at 2 19 29 pm

Search block without the wrapper class

Screenshot 2020-10-26 at 2 19 12 pm

@talldan talldan added [Priority] High Used to indicate top priority items that need quick attention [Type] Regression Related to a regression in the latest release labels Oct 26, 2020
@talldan
Copy link
Contributor Author

talldan commented Oct 26, 2020

This is possibly fixed by WordPress/wordpress-develop#640, but I'm not completely sure.

@oandregal oandregal self-assigned this Oct 26, 2020
@talldan
Copy link
Contributor Author

talldan commented Oct 26, 2020

Just to confirm why it was closed, this is fixed by WordPress/wordpress-develop#640.

@oandregal
Copy link
Member

oandregal commented Oct 26, 2020

@tellthemachines for awareness.

As far as my testing goes, this error was only reproducible with WordPress 5.6 beta1 + Gutenberg master. The variations I've tested are:

WP 5.6 beta1, no gutenberg plugin => fine.
WP 5.6 beta1, gutenberg 9.2.1 => fine.
WP 5.6 beta1, gutenberg master => no class attached for dynamic blocks + PHP errors.

WP 5.6 beta1 + WordPress/wordpress-develop#640, no gutenberg => fine.
WP 5.6 beta1 + WordPress/wordpress-develop#640, gutenberg 9.2.1 => fine.
WP 5.6 beta1 + WordPress/wordpress-develop#640, gutenberg master => fine.

WP 5.5, no gutenberg => fine.
WP 5.5, gutenberg 9.2.1 => fine.
WP 5.5, gutenberg master => fine.

@oandregal
Copy link
Member

For full context: it turns out that in the widget screen (preview widgets) the issue can be reproduced with 5.5.1 and Gutenberg 9.2.1, see #26420 For this to be fixed it needs #26417

@tellthemachines
Copy link
Contributor

Thanks, @nosolosw !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Priority] High Used to indicate top priority items that need quick attention [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

No branches or pull requests

4 participants