-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Template Navigation: Should open to the "Templates" panel when editing a template #26924
Comments
@jameskoster Not sure I understand this. Are you saying that we should open the drawer straight into a nested menu? On the other hand, given how more important templates are compared to the other element in the navigation's root, I'd argue that we might want to show them in the root as well, instead of nesting.
(I'd personally nest template parts away, but I'm not exactly sure where to position its parent navigational item ("Template Parts >") |
Nesting Template Parts inside the Templates panel could work. Let's try that? It is important though to keep in mind that one of the key benefits of using the drilldown pattern is that it can contain many nested levels, and open to contextually relevant panels as required. So I'm not sure I'd say it's an anti pattern. You can compare the UX to clicking a Settings link in an app on iOS. Doing so often takes you to a nested panel in the Settings app itself. |
If I'm not misunderstanding, what you mean is basically what already happens in the Site Editor: if you click "Browse all templates" in the document settings popover, that opens the sidebar directly in the templates menu. (It seems broken right now, but that's unrelated). I'm not opposed to links outside the sidebar opening the sidebar at a nested menu. |
100% - If we are going to start opening the panel to the most contextual menu, we would need the 'back to dashboard' button on every menu. Is that something that would be acceptable? I do understand the argument for opening to the most relevant menu, but 'back to dashboard' definitely needs to be easily found when clicking the toggle button to open the panel.
This seems like a confusing idea. Template parts are not a type or subset of templates and their behavior is quite different both in practical application and potentially in persistence across theme switching. Voting not to conflate these two items together.
Should be fixed now 👍 |
I respectfully disagree. This point was raised as a potential issue during the original design process – and I do not entirely disregard it – but during extensive usability testing of this pattern it did not appear to be an issue. May I request that we open up a PR to at least try the concept? :) I would also add that it has always been the intention that the W button in the content editor would open either the Posts or Pages panel of the navigation, based on what you're editing. So this will not be a unique behaviour. |
Sure! It should be a very simple change, so it's not like we'd be wasting hours behind it. 🙂 I've still got a strong opinion about the "back to dashboard" button though. |
As I said I do not disregard the concern, but ultimately there are two separate considerations here.
I see that being critical to the overall navigation pattern, and a key part of this particular PR.
That may end up being something we address separately. |
Upon opening the navigation drawer whilst editing a template you are currently presented with the "Theme" panel:
I think it makes more sense to open this to the "Templates" panel:
The text was updated successfully, but these errors were encountered: