Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide defaults for font weight/styles on FSE based on the json #27269

Open
MaggieCabrera opened this issue Nov 25, 2020 · 0 comments
Open

Provide defaults for font weight/styles on FSE based on the json #27269

MaggieCabrera opened this issue Nov 25, 2020 · 0 comments
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Type] Enhancement A suggestion for improvement.

Comments

@MaggieCabrera
Copy link
Contributor

In the same vein as #27116 we should provide a default style for some basic tags using the values from theme.json. The editor is already providing specific values, but I believe these should come from the json when they are provided and also affect the frontend so they don't need to be declared within the theme such as these:


b,
strong {
	font-weight: var(--wp--preset--font-weight--bold);
}

dfn,
cite,
em,
i {
	font-style: var(--wp--preset--font-style--italic);
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants