Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customizing the no-results behavior of the query block #27302

Closed
aristath opened this issue Nov 26, 2020 · 4 comments
Closed

Allow customizing the no-results behavior of the query block #27302

aristath opened this issue Nov 26, 2020 · 4 comments
Labels
[Block] Query Loop Affects the Query Loop Block [Type] Feature New feature to highlight in changelogs.

Comments

@aristath
Copy link
Member

Came up in #25790
We should allow users to customize the behavior of the query block when no results are found.

@aristath aristath added [Feature] Full Site Editing [Type] Feature New feature to highlight in changelogs. [Block] Query Loop Affects the Query Loop Block labels Nov 26, 2020
@annezazu
Copy link
Contributor

annezazu commented Mar 3, 2021

Pulling from the FSE Outreach Program's latest call for testing, wanted to mention this piece of feedback as this issue is considered:

when a Query block has been inserted but is empty (i.e. no post content), markup for the block is still output to the front-end: <ul class=”wp-block-query-loop”></ul>. This will likely also create additional white-space on the front-end, due to a top margin being applied to the <ul> tag.

@ntsekouras
Copy link
Contributor

when a Query block has been inserted but is empty (i.e. no post content), markup for the block is still output to the front-end: <ul class=”wp-block-query-loop”></ul>. This will likely also create additional white-space on the front-end, due to a top margin being applied to the <ul> tag.

Thanks for reporting this @annezazu! I created a small PR to fix this: #29521

@ramonjd
Copy link
Member

ramonjd commented Feb 2, 2022

Here is a duplicate issue, which provide some elaboration on the challenge: #36609

@annezazu
Copy link
Contributor

annezazu commented Apr 6, 2022

I am going to close this out with the introduction of @carolinan no results block: #38806 If I missed something, let me know. Happy to reopen.

@annezazu annezazu closed this as completed Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Query Loop Affects the Query Loop Block [Type] Feature New feature to highlight in changelogs.
Projects
None yet
Development

No branches or pull requests

4 participants