Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Selection: Partial block multiselection #27481

Closed
mogmarsh opened this issue Dec 3, 2020 · 4 comments · Fixed by #38892
Closed

Block Selection: Partial block multiselection #27481

mogmarsh opened this issue Dec 3, 2020 · 4 comments · Fixed by #38892
Labels
[Feature] Block Multi Selection The ability to select and manipulate multiple blocks [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Type] Enhancement A suggestion for improvement.

Comments

@mogmarsh
Copy link

mogmarsh commented Dec 3, 2020

This request was discussed in #3629 but that issue has been closed with the note "We should open follow up issues for additional enhancements like partial block selection...". I'm not finding a follow up issue on Partial Block selection, so I am opening a new one.

The basic request is to be able to select some content from one block and some content from the next block, without it selecting all of both blocks. This would allow an Editor to combine two paragraphs by deleting the end of the first paragraph and the beginning of the second paragraph.

The animation in #3629 (comment) demonstrates the issue well:
example animation of selecting blocks
@talldan talldan added [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Type] Enhancement A suggestion for improvement. labels Dec 4, 2020
@ntsekouras ntsekouras added the [Feature] Block Multi Selection The ability to select and manipulate multiple blocks label Dec 4, 2020
@hussain-t hussain-t mentioned this issue Jan 19, 2022
Closed
8 tasks
@gziolo
Copy link
Member

gziolo commented Jan 20, 2022

This feature has just landed in Notion:
https://twitter.com/notionhq/status/1483884489235255297

They are still working with the Mozilla team to enable it in Firefox.

@gziolo gziolo changed the title Partial Block Selection Block Selection: Partial Block Multiselection Jan 20, 2022
@gziolo gziolo changed the title Block Selection: Partial Block Multiselection Block Selection: Partial block multiselection Jan 20, 2022
@mtias
Copy link
Member

mtias commented Jan 20, 2022

Curious if there are any implementation details worth sharing!

@Mamaduka
Copy link
Member

Looks like it took a lot of work to add this feature - https://twitter.com/jitl/status/1483918085384028163.

@ellatrix ellatrix mentioned this issue Mar 16, 2022
Merged
8 tasks
@ellatrix
Copy link
Member

This feature was added with #38892. Would be good to get more testing in trunk before it's in the next Gutenberg release and the next WP release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Block Multi Selection The ability to select and manipulate multiple blocks [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Multi-selection: allow partial block selection WordPress/gutenberg
7 participants
@Mamaduka @mtias @talldan @gziolo @ellatrix @mogmarsh @ntsekouras