Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot undo image resizing #2775

Closed
ellatrix opened this issue Sep 23, 2017 · 7 comments
Closed

Cannot undo image resizing #2775

ellatrix opened this issue Sep 23, 2017 · 7 comments
Labels
[Feature] Media Anything that impacts the experience of managing media [Type] Enhancement A suggestion for improvement.

Comments

@ellatrix
Copy link
Member

Once I have resized an image, there is no way to remove the fixed size to let it be responsive again. I guess I would expect there to be an option responsive/fixed, that automatically switches to fixed if you start resizing.

Similarly, with image resizing enabled, I'm a bit afraid that users will resize an image back to what looks like full-width and then think it's full-width. In reality that won't be the case if the image is displayed in a box that has a different width. I wonder if it might be more interesting to have preset responsive sizes.

@ellatrix ellatrix added the [Feature] Media Anything that impacts the experience of managing media label Sep 23, 2017
@karmatosed karmatosed added the [Type] Bug An existing feature does not function as intended label Sep 24, 2017
@mtias
Copy link
Member

mtias commented Nov 20, 2017

This works now.

@mtias mtias closed this as completed Nov 20, 2017
@aduth
Copy link
Member

aduth commented Feb 5, 2018

In what way is this working? It's unclear to me how to remove custom sizing from an image which had been previously resized.

Raised by @bobbingwide

Reopening in case it's still not possible; unsure if the original issue was related specifically to Undo/Redo, but it seems reasonable to me we should want to allow a user to unset the custom size when editing a post at a later date (i.e. when Undo history doesn't apply).

@aduth aduth reopened this Feb 5, 2018
@mtias
Copy link
Member

mtias commented Mar 6, 2018

Using alignment buttons can reset the resizing. Might be worth adding a button on the inspector for it. cc @jasmussen

@mtias mtias added [Type] Enhancement A suggestion for improvement. and removed [Type] Bug An existing feature does not function as intended labels Mar 6, 2018
@jasmussen
Copy link
Contributor

It doesn't seem like you can unset the resizing in the classic editor, or at least I couldn't find a way:

imagesizing

That's not to say we can't do better in Gutenberg, we certainly can. Here are some mockups created for a pull request:

screen shot 2018-03-07 at 09 53 42

In this, you have additional inspector options for images. There are explicit dimension input fields, quick shortcuts to set scaling sizes, and a button to reset the size.

@mtias
Copy link
Member

mtias commented Mar 7, 2018

Yes, let's go with that.

@mtias mtias closed this as completed Mar 7, 2018
@bobbingwide
Copy link
Contributor

I must be missing something here.

  1. Joen said he couldn't find a way with the classic editor. Even though the image does not appear to change inside the editor, saving and viewing shows that the image size does get changed. Switch to text view.
  2. What does "Let's go with that" mean?

Perhaps you could explain to me what a status of Closed means for this project.

@jasmussen
Copy link
Contributor

@bobbingwide Matías was a bit brief in his comment there. He forgot to suggest the reason for closing, which was to consolidate tickets. Turns out there's already a ticket that touches on this same issue: #4914

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Media Anything that impacts the experience of managing media [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

6 participants