wp-env with "core: null" installs WP 5.4.2, not the latest version (5.6.0) #27763

leoloso · 2020-12-16T15:15:51Z

Describe the bug
When installing wp-env with "core: null", the latest version of WordPress should be installed.

However that is not happening: WordPress 5.4.2 is being installed instead.

To reproduce
Steps to reproduce the behavior:

Use this wp-env.json file:

{
    "core": null
}

Run wp-env start
Go to the admin and the WordPress about page, or check the information in the Docker container

Expected behavior
The latest version of WordPress should be installed (currently 5.6.0)

Screenshots

Desktop (please complete the following information):

OS: MacOS

The text was updated successfully, but these errors were encountered:

talldan · 2020-12-17T06:31:47Z

@leoloso When I tested it used whatever version of WordPress I had installed previously. For me that was 5.6, I'm guessing you had 5.4.2 installed previously using wp-env?

I'll label as a bug though this could probably be handled as a documentation update.

leoloso · 2020-12-17T06:50:35Z

I possibly did have WP 5.4.2, tbh I don't know. However, I also created a new folder and run wp-env start there, and it also installed WP 5.4.2, and there was no previous history there.

If the history doesn't belong to the project but to wp-env, then how I can force it to truly install the latest version of WP? The documentation doesn't mention this.

Btw, I also set-up the config below:

{
    "core": "WordPress/WordPress#5.6.0"
}

But it fails, with this error:

✖ unable to parse OID - contains invalid characters
Error: unable to parse OID - contains invalid characters
    at downloadGitSource (/usr/local/lib/node_modules/@wordpress/env/lib/download-source.js:115:20)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at async downloadSource (/usr/local/lib/node_modules/@wordpress/env/lib/download-source.js:35:3)
    at async /usr/local/lib/node_modules/@wordpress/env/lib/commands/start.js:79:5
    at async Promise.all (index 1)
    at async start (/usr/local/lib/node_modules/@wordpress/env/lib/commands/start.js:70:2)

(Is this an unrelated bug? Should I create another issue?)

talldan · 2020-12-17T07:10:05Z

It uses git refs after the hash, so for a tag this works (this is actually how I have mine set up):

{
    "core": "WordPress/WordPress#tags/5.6"
}

The list of tags is here:
https://github.com/WordPress/WordPress/tags

leoloso · 2020-12-17T07:14:39Z

Ok, thanks. I think the documentation could be improved then, since it doesn't mention anything about tags.

I got it wrong by following the example here:

{
    "core": "WordPress/WordPress#5.2.0",
    "plugins": [ "WordPress/wp-lazy-loading", "WordPress/classic-editor" ],
    "themes": [ "WordPress/theme-experiments" ]
}

talldan · 2020-12-17T07:22:15Z

Good catch!

leoloso · 2020-12-17T07:25:07Z

Also this:

If the history doesn't belong to the project but to wp-env, then how I can force it to truly install the latest version of WP? The documentation doesn't mention this.

Can this be done? Is it a documentation issue? Or there's no way currently to say "use the latest WP" and I need to explicitly use the latest tag?

swissspidy · 2020-12-17T13:51:03Z

If it's not a documentation feature but instead a lacking feature, it could be implemented by fetching the version information from http://api.wordpress.org/core/version-check/1.7/

Note the http. http serves a single offer, whereas https serves multiple. we only want one.

noisysocks · 2021-01-06T04:48:49Z

core: null instructs wp-env to use whatever version of WordPress comes in the wordpress Docker image. Probably that image needs to be updated.

noahtallen · 2021-01-06T17:37:55Z

Yeah, @noisysocks is spot on. They seem to update that image fairly quickly. In this case, it was updated to 5.6 the day of the release (december 8). So then the question is: why were you still getting an out of date image after that point? I think this would be because Docker is using a cached version of the image on your system. (That's my best guess anyways.) If you run wp-env start --update, it will update the docker image for you, which should resolve the problem if I'm right about the image being cached.

I think our action items here are to update the documentation about this behavior, and to fix the example with the git tag

leoloso · 2021-01-07T01:43:50Z

If you run wp-env start --update, it will update the docker image for you, which should resolve the problem if I'm right about the image being cached.

I just tried this, both on an existing installation, and on a new one. It didn't solve the issue: It still installs WP 5.4.2.

Just in case it helps, this is the output in the terminal:

$ wp-env start --update --debug
ℹ Config:
{
    "name": "wp-env-new",
    "configDirectoryPath": "/Users/mac/Temporary/wp-env-new",
    "workDirectoryPath": "/Users/mac/.wp-env/95e90ef32f3edbefda6b5b3e4dc124b6",
    "port": 7088,
    "testsPort": 7089,
    "dockerComposeConfigPath": "/Users/mac/.wp-env/95e90ef32f3edbefda6b5b3e4dc124b6/docker-compose.yml",
    "coreSource": null,
    "pluginSources": [
        {
            "type": "local",
            "path": "/Users/mac/GitRepos/GitHub/Plugins/GraphQLAPI/graphql-api-for-wp",
            "basename": "graphql-api-for-wp"
        }
    ],
    "themeSources": [],
    "config": {
        "WP_DEBUG_DISPLAY": true,
        "GRAPHQL_API_PLUGIN_ENVIRONMENT": "development",
        "WP_TESTS_DOMAIN": "localhost:7089"
    },
    "mappings": {},
    "debug": true
}

Docker Compose Config:
{
    "version": "3.7",
    "services": {
        "mysql": {
            "image": "mariadb",
            "ports": [
                "3306"
            ],
            "environment": {
                "MYSQL_ALLOW_EMPTY_PASSWORD": "yes"
            },
            "volumes": [
                "mysql:/var/lib/mysql"
            ]
        },
        "wordpress": {
            "depends_on": [
                "mysql"
            ],
            "image": "wordpress",
            "ports": [
                "${WP_ENV_PORT:-7088}:80"
            ],
            "environment": {
                "WORDPRESS_DB_NAME": "wordpress"
            },
            "volumes": [
                "wordpress:/var/www/html",
                "/Users/mac/GitRepos/GitHub/Plugins/GraphQLAPI/graphql-api-for-wp:/var/www/html/wp-content/plugins/graphql-api-for-wp"
            ]
        },
        "tests-wordpress": {
            "depends_on": [
                "mysql"
            ],
            "image": "wordpress",
            "ports": [
                "${WP_ENV_TESTS_PORT:-7089}:80"
            ],
            "environment": {
                "WORDPRESS_DB_NAME": "tests-wordpress"
            },
            "volumes": [
                "tests-wordpress:/var/www/html",
                "/Users/mac/GitRepos/GitHub/Plugins/GraphQLAPI/graphql-api-for-wp:/var/www/html/wp-content/plugins/graphql-api-for-wp"
            ]
        },
        "cli": {
            "depends_on": [
                "wordpress"
            ],
            "image": "wordpress:cli",
            "volumes": [
                "wordpress:/var/www/html",
                "/Users/mac/GitRepos/GitHub/Plugins/GraphQLAPI/graphql-api-for-wp:/var/www/html/wp-content/plugins/graphql-api-for-wp"
            ],
            "user": "33:33"
        },
        "tests-cli": {
            "depends_on": [
                "tests-wordpress"
            ],
            "image": "wordpress:cli",
            "volumes": [
                "tests-wordpress:/var/www/html",
                "/Users/mac/GitRepos/GitHub/Plugins/GraphQLAPI/graphql-api-for-wp:/var/www/html/wp-content/plugins/graphql-api-for-wp"
            ],
            "user": "33:33"
        },
        "composer": {
            "image": "composer",
            "volumes": [
                "/Users/mac/Temporary/wp-env-new:/app"
            ]
        },
        "phpunit": {
            "image": "wordpressdevelop/phpunit:${LOCAL_PHP-latest}",
            "depends_on": [
                "tests-wordpress"
            ],
            "volumes": [
                "tests-wordpress:/var/www/html",
                "/Users/mac/GitRepos/GitHub/Plugins/GraphQLAPI/graphql-api-for-wp:/var/www/html/wp-content/plugins/graphql-api-for-wp",
                "phpunit-uploads:/var/www/html/wp-content/uploads"
            ],
            "environment": {
                "LOCAL_DIR": "html",
                "WP_PHPUNIT__TESTS_CONFIG": "/var/www/html/phpunit-wp-config.php"
            }
        }
    },
    "volumes": {
        "wordpress": {},
        "tests-wordpress": {},
        "mysql": {},
        "phpunit-uploads": {}
    }
}
⠏ Stopping WordPress.Removing network 95e90ef32f3edbefda6b5b3e4dc124b6_default
Network 95e90ef32f3edbefda6b5b3e4dc124b6_default not found.
ℹ Config:
{
    "name": "wp-env-new",
    "configDirectoryPath": "/Users/mac/Temporary/wp-env-new",
    "workDirectoryPath": "/Users/mac/.wp-env/95e90ef32f3edbefda6b5b3e4dc124b6",
    "port": 7088,
    "testsPort": 7089,
    "dockerComposeConfigPath": "/Users/mac/.wp-env/95e90ef32f3edbefda6b5b3e4dc124b6/docker-compose.yml",
    "coreSource": null,
    "pluginSources": [
        {
            "type": "local",
            "path": "/Users/mac/GitRepos/GitHub/Plugins/GraphQLAPI/graphql-api-for-wp",
            "basename": "graphql-api-for-wp"
        }
    ],
    "themeSources": [],
    "config": {
        "WP_DEBUG_DISPLAY": true,
        "GRAPHQL_API_PLUGIN_ENVIRONMENT": "development",
        "WP_TESTS_DOMAIN": "localhost:7089"
    },
    "mappings": {},
    "debug": true
}

Docker Compose Config:
{
    "version": "3.7",
    "services": {
        "mysql": {
            "image": "mariadb",
            "ports": [
                "3306"
            ],
            "environment": {
                "MYSQL_ALLOW_EMPTY_PASSWORD": "yes"
            },
            "volumes": [
                "mysql:/var/lib/mysql"
            ]
        },
        "wordpress": {
            "depends_on": [
                "mysql"
            ],
            "image": "wordpress",
            "ports": [
                "${WP_ENV_PORT:-7088}:80"
            ],
            "environment": {
                "WORDPRESS_DB_NAME": "wordpress"
            },
            "volumes": [
                "wordpress:/var/www/html",
                "/Users/mac/GitRepos/GitHub/Plugins/GraphQLAPI/graphql-api-for-wp:/var/www/html/wp-content/plugins/graphql-api-for-wp"
            ]
        },
        "tests-wordpress": {
            "depends_on": [
                "mysql"
            ],
            "image": "wordpress",
            "ports": [
                "${WP_ENV_TESTS_PORT:-7089}:80"
            ],
            "environment": {
                "WORDPRESS_DB_NAME": "tests-wordpress"
            },
            "volumes": [
                "tests-wordpress:/var/www/html",
                "/Users/mac/GitRepos/GitHub/Plugins/GraphQLAPI/graphql-api-for-wp:/var/www/html/wp-content/plugins/graphql-api-for-wp"
            ]
        },
        "cli": {
            "depends_on": [
                "wordpress"
            ],
            "image": "wordpress:cli",
            "volumes": [
                "wordpress:/var/www/html",
                "/Users/mac/GitRepos/GitHub/Plugins/GraphQLAPI/graphql-api-for-wp:/var/www/html/wp-content/plugins/graphql-api-for-wp"
            ],
            "user": "33:33"
        },
        "tests-cli": {
            "depends_on": [
                "tests-wordpress"
            ],
            "image": "wordpress:cli",
            "volumes": [
                "tests-wordpress:/var/www/html",
                "/Users/mac/GitRepos/GitHub/Plugins/GraphQLAPI/graphql-api-for-wp:/var/www/html/wp-content/plugins/graphql-api-for-wp"
            ],
            "user": "33:33"
        },
        "composer": {
            "image": "composer",
            "volumes": [
                "/Users/mac/Temporary/wp-env-new:/app"
            ]
        },
        "phpunit": {
            "image": "wordpressdevelop/phpunit:${LOCAL_PHP-latest}",
            "depends_on": [
                "tests-wordpress"
            ],
            "volumes": [
                "tests-wordpress:/var/www/html",
                "/Users/mac/GitRepos/GitHub/Plugins/GraphQLAPI/graphql-api-for-wp:/var/www/html/wp-content/plugins/graphql-api-for-wp",
                "phpunit-uploads:/var/www/html/wp-content/uploads"
            ],
            "environment": {
                "LOCAL_DIR": "html",
                "WP_PHPUNIT__TESTS_CONFIG": "/var/www/html/phpunit-wp-config.php"
            }
        }
    },
    "volumes": {
        "wordpress": {},
        "tests-wordpress": {},
        "mysql": {},
        "phpunit-uploads": {}
    }
}
⠇ Downloading WordPress.Creating network "95e90ef32f3edbefda6b5b3e4dc124b6_default" with the default driver
⠋ Downloading WordPress.Creating volume "95e90ef32f3edbefda6b5b3e4dc124b6_wordpress" with default driver
Creating volume "95e90ef32f3edbefda6b5b3e4dc124b6_tests-wordpress" with default driver
Creating volume "95e90ef32f3edbefda6b5b3e4dc124b6_mysql" with default driver
Creating volume "95e90ef32f3edbefda6b5b3e4dc124b6_phpunit-uploads" with default driver
Creating 95e90ef32f3edbefda6b5b3e4dc124b6_mysql_1 ... done
⠏ Starting WordPress.95e90ef32f3edbefda6b5b3e4dc124b6_mysql_1 is up-to-date
Creating 95e90ef32f3edbefda6b5b3e4dc124b6_wordpress_1       ... done
Creating 95e90ef32f3edbefda6b5b3e4dc124b6_tests-wordpress_1 ... done
Creating 95e90ef32f3edbefda6b5b3e4dc124b6_cli_run ... done
⠋ Starting WordPress.mysqlcheck: Got error: 2002: Can't connect to MySQL server on 'mysql' (115) when trying to connect
Creating 95e90ef32f3edbefda6b5b3e4dc124b6_cli_run ... done
⠸ Starting WordPress.mysqlcheck: Got error: 2002: Can't connect to MySQL server on 'mysql' (115) when trying to connect
Creating 95e90ef32f3edbefda6b5b3e4dc124b6_cli_run ... done
⠸ Starting WordPress.mysqlcheck: Got error: 2002: Can't connect to MySQL server on 'mysql' (115) when trying to connect
Creating 95e90ef32f3edbefda6b5b3e4dc124b6_cli_run ... done
⠋ Starting WordPress.mysqlcheck: Got error: 2002: Can't connect to MySQL server on 'mysql' (115) when trying to connect
Creating 95e90ef32f3edbefda6b5b3e4dc124b6_cli_run ... done
⠧ Starting WordPress.Success: Database checked.
⠇ Starting WordPress.Creating 95e90ef32f3edbefda6b5b3e4dc124b6_cli_run ... 
Creating 95e90ef32f3edbefda6b5b3e4dc124b6_tests-cli_run ... done
⠏ Starting WordPress.Success: WordPress installed successfully.
⠼ Starting WordPress.Success: WordPress installed successfully.
Creating 95e90ef32f3edbefda6b5b3e4dc124b6_cli_run ... done
Creating 95e90ef32f3edbefda6b5b3e4dc124b6_tests-cli_run ... done
⠇ Starting WordPress.Success: Added the constant 'WP_DEBUG_DISPLAY' to the 'wp-config.php' file with the raw value 'true'.
⠦ Starting WordPress.Success: Added the constant 'WP_DEBUG_DISPLAY' to the 'wp-config.php' file with the raw value 'true'.
Creating 95e90ef32f3edbefda6b5b3e4dc124b6_cli_run ... done
Creating 95e90ef32f3edbefda6b5b3e4dc124b6_tests-cli_run ... done
⠇ Starting WordPress.Success: Added the constant 'GRAPHQL_API_PLUGIN_ENVIRONMENT' to the 'wp-config.php' file with the value 'development'.
⠦ Starting WordPress.Success: Added the constant 'GRAPHQL_API_PLUGIN_ENVIRONMENT' to the 'wp-config.php' file with the value 'development'.
Creating 95e90ef32f3edbefda6b5b3e4dc124b6_cli_run ... done
Creating 95e90ef32f3edbefda6b5b3e4dc124b6_tests-cli_run ... done
⠋ Starting WordPress.Success: Added the constant 'WP_TESTS_DOMAIN' to the 'wp-config.php' file with the value 'localhost:7089'.
Success: Added the constant 'WP_TESTS_DOMAIN' to the 'wp-config.php' file with the value 'localhost:7089'.
Creating 95e90ef32f3edbefda6b5b3e4dc124b6_cli_run ... done
Creating 95e90ef32f3edbefda6b5b3e4dc124b6_tests-cli_run ... done
⠏ Starting WordPress.Warning: Could not activate the 'graphql-api-for-wp' plugin.
Success: Activated 1 of 1 plugins.
⠙ Starting WordPress.Warning: Could not activate the 'graphql-api-for-wp' plugin.
⠹ Starting WordPress.Success: Activated 1 of 1 plugins.
✔ WordPress started. (in 82s 465ms)

mburridge · 2023-06-08T13:22:30Z

I am not able to reproduce this problem. It's over two years old so it may have been fixed. Is there still a documentation issue outstanding? I'm going to close this, given the lack of activity over the last couple of years, but feel free to let me know if you feel it's still relevant and I'll re-open it.

noahtallen · 2023-06-13T00:56:03Z

The wp-env behavior has definitely been updated so that the latest version is pulled more quickly, which matches the documented behavior. (So I removed the documentation label)

talldan added [Tool] Env /packages/env Needs Testing Needs further testing to be confirmed. [Type] Bug An existing feature does not function as intended and removed Needs Testing Needs further testing to be confirmed. labels Dec 17, 2020

talldan added the [Type] Developer Documentation Documentation for developers label Dec 17, 2020

swissspidy mentioned this issue Jan 4, 2021

Use @wordpress/env (wp-env) for local dev environment GoogleForCreators/web-stories-wp#5612

Closed

1 task

swissspidy mentioned this issue May 24, 2022

Update repo local environment setup ampproject/amp-wp#6802

Merged

8 tasks

mburridge self-assigned this Mar 30, 2023

mburridge closed this as completed Jun 8, 2023

noahtallen removed the [Type] Developer Documentation Documentation for developers label Jun 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

wp-env with "core: null" installs WP 5.4.2, not the latest version (5.6.0) #27763

wp-env with "core: null" installs WP 5.4.2, not the latest version (5.6.0) #27763

leoloso commented Dec 16, 2020 •

edited

Loading

talldan commented Dec 17, 2020

leoloso commented Dec 17, 2020 •

edited

Loading

talldan commented Dec 17, 2020

leoloso commented Dec 17, 2020

talldan commented Dec 17, 2020

leoloso commented Dec 17, 2020

swissspidy commented Dec 17, 2020

noisysocks commented Jan 6, 2021

noahtallen commented Jan 6, 2021

leoloso commented Jan 7, 2021

mburridge commented Jun 8, 2023 •

edited

Loading

noahtallen commented Jun 13, 2023

wp-env with "core: null" installs WP 5.4.2, not the latest version (5.6.0) #27763

wp-env with "core: null" installs WP 5.4.2, not the latest version (5.6.0) #27763

Comments

leoloso commented Dec 16, 2020 • edited Loading

talldan commented Dec 17, 2020

leoloso commented Dec 17, 2020 • edited Loading

talldan commented Dec 17, 2020

leoloso commented Dec 17, 2020

talldan commented Dec 17, 2020

leoloso commented Dec 17, 2020

swissspidy commented Dec 17, 2020

noisysocks commented Jan 6, 2021

noahtallen commented Jan 6, 2021

leoloso commented Jan 7, 2021

mburridge commented Jun 8, 2023 • edited Loading

noahtallen commented Jun 13, 2023

leoloso commented Dec 16, 2020 •

edited

Loading

leoloso commented Dec 17, 2020 •

edited

Loading

mburridge commented Jun 8, 2023 •

edited

Loading