Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reusable blocks: width settings not retained when full-width block made reusable. #28024

Closed
rickybanister opened this issue Jan 6, 2021 · 1 comment
Labels
[Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed

Comments

@rickybanister
Copy link

Describe the bug
I added columns to my document, put some things inside them, decided I wanted my layout to be full width and changed that setting on the parent columns block. I then converted it to 'reusable' for use elsewhere. In the process my width setting was lost and my reusable block became the standard document width.

To reproduce
Steps to reproduce the behavior:

  1. Create a new page.
  2. Add a columns block and put content inside it.
  3. Set the columns parent alignment to 'full width'.
  4. Convert it to 'reusable'.
  5. See the width jump back to default.

Expected behavior
I expected the 'reusable block' to just be a dumb wrapper and retain all my inner settings. I could get those back by 'converting to regular blocks', but then I'd lose the advantage of having cascading changes to the inner blocks. Perhaps another solution would be to provide alignment options for the reusable block wrapper, but I'm not sure that would solve the issue.

Screenshots
Columns block set to 'full width':
image

After converting to reusable:
image

@talldan talldan changed the title Reusable blocks: width settings not retained when columns block made reusable. Reusable blocks: width settings not retained when full-width block made reusable. Jan 7, 2021
@talldan
Copy link
Contributor

talldan commented Jan 7, 2021

I think this issue is covered by #17640, adding an alignment option to the reusable block toolbar would solve the problem, so I'll close this in favour of that issue.

@talldan talldan closed this as completed Jan 7, 2021
@talldan talldan added the [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed label Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed
Projects
None yet
Development

No branches or pull requests

2 participants