Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static Analysis workflow failing #28027

Closed
ockham opened this issue Jan 6, 2021 · 0 comments · Fixed by #28034
Closed

Static Analysis workflow failing #28027

ockham opened this issue Jan 6, 2021 · 0 comments · Fixed by #28034
Assignees
Labels
[Priority] High Used to indicate top priority items that need quick attention [Status] In Progress Tracking issues with work in progress [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Bug An existing feature does not function as intended

Comments

@ockham
Copy link
Contributor

ockham commented Jan 6, 2021

Describe the bug
It seems like after the release of GB 9.7 earlier today, the Static Analysis workflow fails for newly created PRs because of this:

deprecated( 'leftSidebar prop in InterfaceSkeleton component', {
alternative: 'secondarySidebar prop',
version: '9.7.0',
plugin: 'Gutenberg',
} );

The error is:

 75:4  error  Deprecated functions must be removed before releasing this version  no-restricted-syntax

Discovered here: #28008 (comment)

To reproduce

Make sure you're local clone of the repo is up-to-date. Create a new branch with some changes and file a PR. Note that the Static Analysis GH action workflow fails.

Expected behavior
That workflow to pass.

cc/ @JustinSainton

@ockham ockham added [Type] Bug An existing feature does not function as intended [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. labels Jan 6, 2021
@ockham ockham added the [Priority] High Used to indicate top priority items that need quick attention label Jan 6, 2021
@gziolo gziolo self-assigned this Jan 7, 2021
@gziolo gziolo added the [Status] In Progress Tracking issues with work in progress label Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Priority] High Used to indicate top priority items that need quick attention [Status] In Progress Tracking issues with work in progress [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants