User-generated templates should be deletable

[jameskoster]

Templates supplied by the theme, that have been customised can be reverted back to their original state.

Templates that have been user generated via the [+] button in the site editing W panel should be deletable.

This flow needs some design exploration to determine where folks should be sent post deletion.

[jameskoster]

First pass at this:

The language in the modal can probably use some optimisation :)

As for where users get sent after deleting the current template, in the future I think they should be sent to the mosaic view – this would be consistent with deleting a post which sends you back to the post list.

Until we have the mosaic view implemented, returning them to the last-edited template seems most sensible to me.

[youknowriad]

I'm about to make things more complex :)

What If I actually want to delete a theme's template? Say theme provides "single.html" but I just want to rely on its ancestor "index.html" ? Maybe not a common-use case and potentially something that can come later though.

[jameskoster]

I'm about to make things more complex :)

Thanks :D

It probably shouldn't be possible to literally delete a theme .html template in the UI, so this might be better framed more as a "Disable" than "Delete". I can certainly see a use case for that though... you might want to temporarily disable a template while you work on it, or as you said, permanently exclude one specific theme template.

Probably worth opening a new issue for this, since the affordance could theoretically be applied to both theme-supplied and user-generated templates.

[jameskoster]

Closing this as it's essentially a duplicate of #31076