Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reusable blocks: Display outlines #28285

Closed
jameskoster opened this issue Jan 18, 2021 · 2 comments
Closed

Reusable blocks: Display outlines #28285

jameskoster opened this issue Jan 18, 2021 · 2 comments
Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks)

Comments

@jameskoster
Copy link
Contributor

In the Site Editor we've been using outlines to help illustrate the boundaries of a template part when it or its children have been selected.

Since template parts and reusable blocks are very similar, it might be worth creating UX alignment between these features. Especially since some of the changes in #27890 degraded the UX a little.

Here's how the outlines would work if we copied the current template part implementation.

Reusable block hovered

Screenshot 2021-01-18 at 12 29 43

A 1px outline in the theme color appears on hover.

Reusable block selected and focussed

Screenshot 2021-01-18 at 12 30 30

The hover outline is increased to 1.5px.

Reusable block selected, not focussed

Screenshot 2021-01-18 at 12 31 02

A 1px outline in $gray-900 appears.

Reusable block child selected

Screenshot 2021-01-18 at 12 37 26

A 1px outline in $gray-900 on the reusable block persists when child blocks are selected.

@jameskoster jameskoster added the [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) label Jan 18, 2021
@jasmussen
Copy link
Contributor

jasmussen commented Jan 18, 2021

Good ticket, I did some initial work in #28283, and am happy to tweak to expand it.

Edit: I added the wrong link!

@mtias
Copy link
Member

mtias commented Jul 14, 2021

Marking this as done now that we have the overlay support.

@mtias mtias closed this as completed Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks)
Projects
None yet
Development

No branches or pull requests

3 participants