Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to return to former placeholder state in a Media & Text block #28535

Closed
smerriman opened this issue Jan 28, 2021 · 7 comments
Closed

Unable to return to former placeholder state in a Media & Text block #28535

smerriman opened this issue Jan 28, 2021 · 7 comments
Labels
[Block] Media & Text Affects the Media & Text Block Needs Decision Needs a decision to be actionable or relevant Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@smerriman
Copy link

Description

When you first insert a Media & Text block, you see a placeholder where an image can be uploaded.

It is possible to save and publish the content without uploading an image. I believe this is intended and think it is a good idea, especially while you're in the process of creating the page and want to get a consistent flow of content before placing images. You may want to retain the layout while keeping the image area blank for the short term.

Once an image is selected, it is impossible to return to the prior state of having a placeholder box without deleting the entire block and starting again.

Step-by-step reproduction instructions

  1. Add a Media & Text block, and add some text content.
  2. Note that the block can be saved and published as is, which places the text to the side.
  3. Upload and select an image.
  4. Note there is no way of removing the image without replacing it with another one.

Expected behaviour

There should be a way of removing the image.

Actual behaviour

There isn't.

WordPress information

  • WordPress version: 5.6.0
  • Gutenberg version: Not installed
  • Are all plugins except Gutenberg deactivated? Yes
  • Are you using a default theme (e.g. Twenty Twenty-One)? Yes
@talldan talldan added [Block] Media & Text Affects the Media & Text Block Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement. Needs Decision Needs a decision to be actionable or relevant and removed Needs Design Feedback Needs general design feedback. labels Jan 28, 2021
@talldan
Copy link
Contributor

talldan commented Jan 28, 2021

Thanks for creating the issue. This isn't really a bug, seems more like a feature request. Currently the block works as designed.

I'm sure this could be done, but I'm not completely sure about the widespread value this feature would have. I'll leave the issue open so that it can gather feedback.

@smerriman
Copy link
Author

smerriman commented Jan 28, 2021

I considered feature request, but the UX issues means it is a bug. If you don't want the ability for a Media & Text block without an image, then it's a bug that you can initially; if you do, then it's a bug that you can't later.

@talldan
Copy link
Contributor

talldan commented Jan 28, 2021

If you don't want the ability for a Media & Text block without an image, then it's a bug that you can initially

The initial state is to allow users to select an image. There's no written rule that says that this operation should be reversible.

@paaljoachim
Copy link
Contributor

Well this is kinda tricky.
When using Gutenberg or any piece of software one will use whatever features are available. Independent of if one is using the feature the "correct" way or not.

In this case it means adding a Media & Text block and just add the text on the right side and no image.

Screen Shot 2021-02-02 at 14 48 04

Frontend:
Screen Shot 2021-02-02 at 14 48 28

A user might be just looking for a simple way to add text to the right like the above screenshot.

The official recommendation would likely be to use the columns block and add two columns. Then add text in the right column.

I am sorry to say it, @smerriman but I believe this is a won't fix issue. As for the Media & Text block the purpose is about adding media and text.

@carolinan
Copy link
Contributor

Initially, there is an undo step that can be used to return to the default state.
The only image block that has a reset is the post-featured image block, so I think this is consistent with the other image blocks.

@kraftner
Copy link

@carolinan Please reconsider this. The undo state only works when you haven't saved and reloaded the page.

This is a huge problem when using the block inside a locked template since there you can't just delete the block. It makes the block basically unusable in such a scenario.

@Mamaduka
Copy link
Member

I'll close the issue. You can now "Reset" media using the media replace dropdown. See #64826.

Screenshot

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Media & Text Affects the Media & Text Block Needs Decision Needs a decision to be actionable or relevant Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

6 participants