Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor: Highlight blocks in the List View when hovered in the canvas #28699

Closed
Copons opened this issue Feb 3, 2021 · 1 comment
Closed
Assignees
Labels
[Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@Copons
Copy link
Contributor

Copons commented Feb 3, 2021

This is intended to be used by the persistent List View (following up to #28637), but it could be addressed in parallel.

When hovering on a block in the canvas, highlight the corresponding list item in the List View (BlockNavigation component).

The highlighting behaviour should be conditional to avoid affecting pre-existing uses that might not need or want it.

Image from #27395

Accessibility concerns

For brevity I've only mentioned the "hover" interaction, but let's also consider the keyboard navigation.

In the likely chance navigating through blocks with the keyboard actually selects them (and not just highlight/focus them), we might either not need to do anything, or discuss with a11y if we want to change such behaviour.

Relationship with #28637

In 083dc90 I've added a new highlightBlocksOnHover prop to the BlockNavigation component to conditionally control the highlight behaviour (from the "opposite direction": hover the list item -> highlight the block in canvas).
We might want to reuse the same prop to control the highlight proposed in this issue.

@Copons Copons added [Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Type] Task Issues or PRs that have been broken down into an individual action to take [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Feb 3, 2021
@jeyip jeyip self-assigned this Feb 18, 2021
@Copons
Copy link
Contributor Author

Copons commented Feb 19, 2021

After talking with @jameskoster, I've realized I missed a discussion where it was decided to not follow through with this.
I'm going to close the issue for now. We can always reopen it at a later time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

No branches or pull requests

2 participants