Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover Block: Make it clear that content has not disappeared when the background is removed #28888

Closed
ianstewart opened this issue Feb 9, 2021 · 1 comment · Fixed by #31402
Closed

Cover Block: Make it clear that content has not disappeared when the background is removed #28888

ianstewart opened this issue Feb 9, 2021 · 1 comment · Fixed by #31402
Assignees
@stokesman
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@ianstewart
Copy link
Contributor

What problem does this address?

When content is nested inside a cover block with a background image and the background image is removed it can make it appear as if the nested blocks have "disappeared". Prompting a "where'd my stuff go?" response.

2021-02-09 09 56 10

What is your proposed solution?

Defaulting instead to a background colour may be more ideal in this case.
@stokesman stokesman added [Block] Cover Affects the Cover Block - used to display content laid over a background image [Type] Enhancement A suggestion for improvement. labels Feb 10, 2021
@synora synora mentioned this issue Feb 15, 2021
Closed
@stokesman stokesman mentioned this issue Apr 28, 2021
Closed
@stokesman stokesman added [Type] Bug An existing feature does not function as intended and removed [Type] Enhancement A suggestion for improvement. labels Apr 28, 2021
@stokesman stokesman changed the title Cover Block: Make it clear that content nested in a cover block has not disappeared when the background media is removed Cover Block: Make it clear that content has not disappeared when the background is removed Apr 28, 2021
@stokesman
Copy link
Contributor

Relabeled this as a bug since I think #31253 makes it clear just how confusing this can be.

@stokesman stokesman mentioned this issue May 2, 2021
Merged
7 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stokesman stokesman

Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show Cover block placeholder only if it has no inner blocks WordPress/gutenberg
2 participants
@ianstewart @stokesman