Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table block markup in the front-end #2904

Closed
samikeijonen opened this issue Oct 6, 2017 · 4 comments
Closed

Table block markup in the front-end #2904

samikeijonen opened this issue Oct 6, 2017 · 4 comments
Labels
[Feature] Blocks Overall functionality of blocks

Comments

@samikeijonen
Copy link
Contributor

samikeijonen commented Oct 6, 2017

Table block have similar issues opened but I leave this here just in case.

<table class="wp-block-table">
	<tr>
		<td>First name</td>
		<td>Last name</td>
	</tr>
	<tr>
		<td>Xami</td>
		<td>Gello</td>
	</tr>
	<tr>
		<td>Zanna</td>
		<td>Petronen</td>
	</tr>
</table>

About CSS:

.wp-block-table {
	overflow-x: auto;
	display: block;

	table {
		border-collapse: collapse;
		width: 100%;
	}
}

All of these styles should be removed, themes already handles table styles. Also generated CSS .wp-block-table table doesn't match any element.

@karmatosed karmatosed added the [Feature] Blocks Overall functionality of blocks label Oct 9, 2017
@mtias
Copy link
Member

mtias commented Oct 10, 2017

cc @androb this might be absorbed by the new table project from tinymce.

@laurelfulford
Copy link
Contributor

Also adding (in case these aren't absorbed by the new table project) that the display: block on the .wp-block-table class "breaks" how tables work -- they're normally display: table, and this at least seems to prevent trs from spanning the whole width.

@danielbachhuber
Copy link
Member

Related #6923

@karmatosed
Copy link
Member

I am going to close this to consolidate all table issues that relate into one issue here: #6923

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks
Projects
None yet
Development

No branches or pull requests

5 participants