Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons Block: Add a way to control vertical space between stacked buttons #29098

Closed
alaczek opened this issue Feb 18, 2021 · 4 comments · Fixed by #33991 or #34546
Closed

Buttons Block: Add a way to control vertical space between stacked buttons #29098

alaczek opened this issue Feb 18, 2021 · 4 comments · Fixed by #33991 or #34546
Assignees
Labels
[Block] Buttons Affects the Buttons Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Needs Design Feedback Needs general design feedback. Needs Design Needs design efforts. [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@alaczek
Copy link

alaczek commented Feb 18, 2021

The introduction of button width control has allowed the creation of designs such as this:

image

This is one Buttons block with 5 buttons inside, each button set to 100% width. The vertical spacing between the buttons is quite small. It would be great to have a way to control the vertical spacing in case of stacked buttons. I'm keen to hear others opinion on this. I know the theme being used will affect this as well, but I think having control over spacing between buttons would be useful anyway.

@paaljoachim
Copy link
Contributor

paaljoachim commented Feb 18, 2021

Hi @alaczek Thank you for adding this issue!

What we can do is add margin controls in the sidebar inside a Dimensions panel (which I believe is the new name for gathering padding and margins into one panel).

Buttons-block-Dimensions-panel

I added the Dimensions panel that will I believe contain margin and padding etc.
Perhaps we will get gutter into the Dimensions panel as well.

Here is an Overview issue: Consistent dimension controls across blocks.
#28356

@ItsJonQ Jon is this correct?
I'll add Joen @jasmussen as well.

@paaljoachim paaljoachim added [Block] Buttons Affects the Buttons Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Needs Design Needs design efforts. Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement. labels Feb 18, 2021
@mtias mtias mentioned this issue Jul 15, 2021
65 tasks
@apeatling
Copy link
Contributor

This will be fixed by #33991

@andrewserong
Copy link
Contributor

Just re-opening this issue: #33991 added in the gap block support feature, but we'll need to opt-in to it for the Buttons block in a separate PR.

@andrewserong andrewserong reopened this Sep 2, 2021
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Sep 3, 2021
@apeatling
Copy link
Contributor

Opt in PR for Buttons block is here #34546

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Buttons Affects the Buttons Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Needs Design Feedback Needs general design feedback. Needs Design Needs design efforts. [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
Status: Done
5 participants