Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Image size settings from Media & Text options #29362

Open
tellthemachines opened this issue Feb 26, 2021 · 1 comment
Open

Remove Image size settings from Media & Text options #29362

tellthemachines opened this issue Feb 26, 2021 · 1 comment
Labels
[Block] Media & Text Affects the Media & Text Block [Type] Enhancement A suggestion for improvement.

Comments

@tellthemachines
Copy link
Contributor

Description

Follow-up from this discussion. Because images in the Media & Text block always take up 100% of their parent width, changing the image size in the block sidebar has no effect except making the image blurry if a small size is chosen. This setting should be removed as it is effectively useless in this block.

Step-by-step reproduction instructions

  1. Add Media & Text block to a post.
  2. In the sidebar settings, change the image size.
  3. Verify image size doesn't change.

Expected behaviour

As, according to the discussion linked to above, the image in this block should always occupy 100% of its area, I would expect the image size setting to not be available in the sidebar.

Screenshots or screen recording (optional)

Screen Shot 2021-02-26 at 3 18 32 pm

@Mamaduka
Copy link
Member

Mamaduka commented Apr 16, 2021

Hi, @tellthemachines

I think size settings were added to control image file size. See #24795 (comment).

But I agree, it's a little confusing. Maybe we should add a description or change the label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Media & Text Affects the Media & Text Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants