Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show keyboard shortcuts in menus and tooltips #2980

Closed
jasmussen opened this issue Oct 11, 2017 · 6 comments
Closed

Show keyboard shortcuts in menus and tooltips #2980

jasmussen opened this issue Oct 11, 2017 · 6 comments
Assignees
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). General Interface Parts of the UI which don't fall neatly under other labels. [Type] Enhancement A suggestion for improvement.

Comments

@jasmussen
Copy link
Contributor

Aside from improving keyboard shortcuts (see #71, #2960) and others, let's discuss how we can surface these keyboard shortcuts to people. In this ticket I'd like to propose three ways we can do this:

1. Show keyboard shortcuts in menus

screen shot 2017-10-11 at 10 10 15

This is a mockup of a redesigned side menu, and the shortcuts are just bad suggestions from me, but the idea is that any menu that holds items with keyboard shortcuts show these shortcuts on the right.

2. Show keyboard shortcuts in tooltips

screen shot 2017-10-11 at 10 11 00

This is helpful in the same way tooltips are helpful.

3. Show a keyboard shortctus sheet when you press Shift+?

This is a common pattern in Google properties, press Shift+? to bring up a sheet that lists all keyboard shortcuts. Here's how it looks in Inbox:

screen shot 2017-10-11 at 10 19 14

Thoughts?

@jasmussen jasmussen added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). General Interface Parts of the UI which don't fall neatly under other labels. Design Needs Design Feedback Needs general design feedback. [Type] Question Questions about the design or development of the editor. labels Oct 11, 2017
@karmatosed
Copy link
Member

I really like this, it's a strong usability improvement for a wide range of users. I also really like the contextual information of having them 'there' when you need them.

@vladanost
Copy link
Contributor

@jasmussen I hope this lands soon, it is a great feature.
Is there a comprehensive list of Gutenberg shortcuts available anywhere at the moment?
Maybe we could have a separate issue for keyboard shortcut requests.
Here is one: Shortcut for switching from Text to Visual editor mode, really handy for development.

@jasmussen
Copy link
Contributor Author

There isn't a keyboard shortcuts list yet, though there's a "todo list" at #71. We should use that ticket to both check off which are done, and which are still missing, I suppose.

@karmatosed karmatosed added [Type] Enhancement A suggestion for improvement. and removed Design Needs Design Feedback Needs general design feedback. [Type] Question Questions about the design or development of the editor. labels Jan 3, 2018
@jasmussen jasmussen mentioned this issue Feb 20, 2018
35 tasks
@afercia
Copy link
Contributor

afercia commented Jul 2, 2018

@jasmussen when you have a chance: going through this issue during today's accessibility bug-scrub: and wondering what's left here?

@jasmussen
Copy link
Contributor Author

I have sort of on my "secret agenda" to create a native extension that uses the incoming Modal API to create a shortcut sheet like the one mocked up in item 3. But even if I never got to that, it's fine to ship without it.

We're missing some shortcuts + indicators in side menus, though I suppose this might be best handled in individual issues, like #7297 perhaps? If you feel that's the case, feel free to close this one.

@talldan
Copy link
Contributor

talldan commented Aug 15, 2018

@jasmussen Will close this now, as I think the three points have been addressed.

@talldan talldan closed this as completed Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). General Interface Parts of the UI which don't fall neatly under other labels. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

6 participants