-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show keyboard shortcuts in menus and tooltips #2980
Comments
I really like this, it's a strong usability improvement for a wide range of users. I also really like the contextual information of having them 'there' when you need them. |
@jasmussen I hope this lands soon, it is a great feature. |
There isn't a keyboard shortcuts list yet, though there's a "todo list" at #71. We should use that ticket to both check off which are done, and which are still missing, I suppose. |
@jasmussen when you have a chance: going through this issue during today's accessibility bug-scrub: and wondering what's left here? |
I have sort of on my "secret agenda" to create a native extension that uses the incoming Modal API to create a shortcut sheet like the one mocked up in item 3. But even if I never got to that, it's fine to ship without it. We're missing some shortcuts + indicators in side menus, though I suppose this might be best handled in individual issues, like #7297 perhaps? If you feel that's the case, feel free to close this one. |
@jasmussen Will close this now, as I think the three points have been addressed. |
Aside from improving keyboard shortcuts (see #71, #2960) and others, let's discuss how we can surface these keyboard shortcuts to people. In this ticket I'd like to propose three ways we can do this:
1. Show keyboard shortcuts in menus
This is a mockup of a redesigned side menu, and the shortcuts are just bad suggestions from me, but the idea is that any menu that holds items with keyboard shortcuts show these shortcuts on the right.
2. Show keyboard shortcuts in tooltips
This is helpful in the same way tooltips are helpful.
3. Show a keyboard shortctus sheet when you press Shift+?
This is a common pattern in Google properties, press Shift+? to bring up a sheet that lists all keyboard shortcuts. Here's how it looks in Inbox:
Thoughts?
The text was updated successfully, but these errors were encountered: