Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gallery refactor: undo doesn't work with keyboard to remove a gallery with images #30001

Closed
glendaviesnz opened this issue Mar 19, 2021 · 2 comments
Closed

Gallery refactor: undo doesn't work with keyboard to remove a gallery with images #30001

glendaviesnz opened this issue Mar 19, 2021 · 2 comments
Assignees
@glendaviesnz
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Type] Bug An existing feature does not function as intended

Comments

@glendaviesnz
Copy link
Contributor

Description

If a gallery is created by dragging and dropping images CMD-Z or Delete key do not work to remove the block. Also of parent gallery is selected the delete key can't be used to delete it as it can with other container blocks. Probably related to #29998

Step-by-step reproduction instructions

Check out gallery refactor PR and turn on refactored gallery experiment
Drag and drop images to create a gallery block. CMD-Z to undo, nothing happens
Select the parent Gallery block and hit Delete key - nothing happens
@glendaviesnz glendaviesnz added [Type] Bug An existing feature does not function as intended [Block] Gallery Affects the Gallery Block - used to display groups of images labels Mar 19, 2021
@glendaviesnz glendaviesnz mentioned this issue Mar 31, 2021
Closed
43 tasks
@glendaviesnz glendaviesnz mentioned this issue Apr 27, 2021
Merged
@glendaviesnz glendaviesnz self-assigned this Apr 28, 2021
@glendaviesnz glendaviesnz changed the title Gallery refactor: undo or delete doesn't work with keyboard to remove a gallery with images Gallery refactor: undo doesn't work with keyboard to remove a gallery with images Apr 28, 2021
@kathrynwp
Copy link

Hi @glendaviesnz I'm just checking to see whether this issue is still applicable and valid now that the refactored gallery is in core.

I only been able to replicate intermittently, but not only with drag-and-dropped gallery images, also with images selected from the Media Library... so I'm not 100% sure I'm testing correctly. Let me know what you think!

WordPress 6.0.1
Gutenberg 13.8.1 active or inactive
No other plugins active
Twenty Twenty-Two 1.2

@glendaviesnz
Copy link
Contributor Author

Let's close this one for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glendaviesnz glendaviesnz

Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Type] Bug An existing feature does not function as intended
Projects
No open projects
Gallery block improvements
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@glendaviesnz @kathrynwp