Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List View: Add ability to remove items #30109

Closed
Tracked by #29733
annezazu opened this issue Mar 22, 2021 · 4 comments
Closed
Tracked by #29733

List View: Add ability to remove items #30109

annezazu opened this issue Mar 22, 2021 · 4 comments
Labels
[Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

What problem does this address?

As part of the third call for testing with the FSE Outreach Program, this came up in the feedback:

Needs power features including a re-order and delete feature for each block.

This was previously discussed here a few years ago #10984 but List View was determined to be a bit too new at the time to be explored further. It was then subsequently closed out.

This might be relevant for @priethor as I see you're gathering a list of improvements here: #29733

What is your proposed solution?

Allow the ability to remove items from the List View. When considering this, I do want to bring in feedback from the previous discussion from @afercia:

Multiple actions on a single UI controls are (maybe) a pattern best suited for mobile applications. On the Web, good semantics is key. An Ui control should have only one, clear, available action. From an accessibility perspective, I'm not opposed to explore extending the functionalities available in the Block Navigation menu, but I'd strongly recommend a separate control (another button) to delete a block. Also, when deleting an item, focus must be managed programmatically, as the previously focused element gets removed and focus must land in the most logical place.

@annezazu annezazu added [Type] Enhancement A suggestion for improvement. [Feature] List View Menu item in the top toolbar to select blocks from a list of links. labels Mar 22, 2021
@talldan
Copy link
Contributor

talldan commented Mar 25, 2021

The block more menu is implemented in list view but inactive currently and that allows deletion - #22427

When I looked at adding this to the post editor, the accessibility team were concerned about the complexity of grid navigation in List View for users, which is needed if we place a more menu or delete button in the row of the list view item: #25034 (comment)

@annezazu
Copy link
Contributor Author

Ah ha! Thank you for sharing the wider context and concerns around accessibility 🙌🏼

@carolinan
Copy link
Contributor

This was also mentioned during user testing on April 9.

@gwwar
Copy link
Contributor

gwwar commented Oct 11, 2021

Closed by #35170 props @noisysocks

@gwwar gwwar closed this as completed Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants