Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link color support (experimental): Add E2E Test #30458

Open
ockham opened this issue Apr 1, 2021 · 0 comments
Open

Link color support (experimental): Add E2E Test #30458

ockham opened this issue Apr 1, 2021 · 0 comments
Labels
[Package] E2E Tests /packages/e2e-tests [Type] Enhancement A suggestion for improvement.

Comments

@ockham
Copy link
Contributor

ockham commented Apr 1, 2021

10.3.0 had a regression (#29535) where for traditional/PHP based themes with add_theme_support( 'experimental-link-color' );, the link color option was available, but the selected color was not applied in the editor or the frontend. Affected themes included Twenty Twenty-One (TT1) -- whereas block-based (FSE) themes (such as TT1 Blocks) were unaffected. The regression was fixed by #30452.

This comment provides good instructions for how to reproduce the issue, and the fix.

We should add an E2E test (based on that comment) -- probably in packages/e2e-tests/specs/experiments -- to guard against regressions like that.

cc/ @WunderBart @fullofcaffeine @rafaelgalani -- any takers? 😄

@ockham ockham added the [Package] E2E Tests /packages/e2e-tests label Apr 1, 2021
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] E2E Tests /packages/e2e-tests [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants