Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Columns block: Dropping blocks below existing content. #30700

Closed
paaljoachim opened this issue Apr 10, 2021 · 8 comments
Closed

Columns block: Dropping blocks below existing content. #30700

paaljoachim opened this issue Apr 10, 2021 · 8 comments
Labels
[Block] Columns Affects the Columns Block [Feature] Drag and Drop Drag and drop functionality when working with blocks [Feature] Widgets Screen The block-based screen that replaced widgets.php. [Type] Bug An existing feature does not function as intended

Comments

@paaljoachim
Copy link
Contributor

paaljoachim commented Apr 10, 2021

What problem does this address?

One can not drop content below the existing Column block content.
One needs to drop above and then use the arrow keys to move the content below.

Only-Drop-block-into-Columns-block-above-current-content.mp4

What is your proposed solution?

One should be able to drop blocks above OR below the existing content in the Columns block.

@shaunandrews

@paaljoachim paaljoachim added [Block] Columns Affects the Columns Block [Type] Enhancement A suggestion for improvement. labels Apr 10, 2021
@shaunandrews
Copy link
Contributor

Funny enough, I have the opposite problem; I can't drop a block at the top of a Column:

column-block-dropping

@paaljoachim
Copy link
Contributor Author

That is weird.
It has a mind of its own.
It looks like a general fix is needed here.

@annezazu annezazu added the [Feature] Drag and Drop Drag and drop functionality when working with blocks label Apr 16, 2021
@annezazu
Copy link
Contributor

@priethor thoughts on whether this is an enhancement request or a bug? To me, this feels like a bug :D

@priethor
Copy link
Contributor

I could see this being limited on purpose but... it does seem like a bug to me, the dropzones are a bit hard to find 😅

@paaljoachim paaljoachim added [Type] Bug An existing feature does not function as intended and removed [Type] Enhancement A suggestion for improvement. labels Apr 18, 2021
@paaljoachim
Copy link
Contributor Author

paaljoachim commented Apr 18, 2021

Here is a suggestion for adding drop zone to the Columns block: #30699

@paaljoachim
Copy link
Contributor Author

I want to also mention this issue is valid for the Widgets screen as well.
I just now tried to drop a block above the current blocks in the Widget screen, but was not able to do so.

Not-able-to-drop-block-above-existing-block-in-widget.mp4

@draganescu

@paaljoachim paaljoachim added the [Feature] Widgets Screen The block-based screen that replaced widgets.php. label May 17, 2021
@talldan
Copy link
Contributor

talldan commented Jun 17, 2021

I think the original issue has been solved, I could definitely drag to the bottom of a column. Dragging to the top works as well, but the blue indicator doesn't show.

I also can't reproduce the widgets issue, just the thing I mentioned before—the blue drop indicator doesn't show at the top and the area that can be dragged into is smaller than expected (see #26049).

@paaljoachim
Copy link
Contributor Author

I noticed a very thin line when dropping below content in a columns block. So the issue I mentioned here has been taken care of. There are various other drag and drop blue lines missing for other circumstances but those have perhaps been addressed in other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Columns Affects the Columns Block [Feature] Drag and Drop Drag and drop functionality when working with blocks [Feature] Widgets Screen The block-based screen that replaced widgets.php. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

5 participants