Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search Block: Change Button Position Does Not Show Indication of What is Selected #30746

Closed
deborah86 opened this issue Apr 12, 2021 · 4 comments
Labels
[Block] Search Affects the Search Block - used to display a search field [Type] Bug An existing feature does not function as intended

Comments

@deborah86
Copy link

Description

The change button position on the search block doesn't show any indication of what option is selected.

Step-by-step reproduction instructions

  1. Add a search block to the editor
  2. Select either no button, button inside, or button outside,

Expected behaviour

The icon of the selected option to have a dark background to indicate that it has been selected.

Actual behaviour

The backgrounds don't change for any of the options selected.

Screenshots or screen recording (optional)

https://1drv.ms/u/s!Agz9k3UFAizZig5eE0CWwaq9bdYR?e=4mNAZ3
image

Code snippet (optional)

WordPress information

  • WordPress version: 5.7

  • Gutenberg version:

  • Are all plugins except Gutenberg deactivated?

  • Are you using a default theme (e.g. Twenty Twenty-One)?

  • WordPress version:

  • Gutenberg version: Not installed

  • Are all plugins except Gutenberg deactivated? Yes, no other plugins are installed

  • Are you using a default theme (e.g. Twenty Twenty-One)? Yes Twenty Twenty-One

Device information

  • Device:

  • Operating system:

  • Browser:

  • Device: Desktop

  • Operating system: Windows 10

  • Browser: Microsoft Edge Version 89.0.774.68

@deborah86 deborah86 changed the title Search Block's Change Button Position Does Not Show Indication of What is Selected Search Block: Change Button Position Does Not Show Indication of What is Selected Apr 12, 2021
@priethor
Copy link
Contributor

Thanks for reporting @deborah86 ! I can reproduce this issue with Gutenberg 10.4-RC1 as well.

@priethor priethor added [Block] Search Affects the Search Block - used to display a search field [Type] Bug An existing feature does not function as intended labels Apr 12, 2021
@javierarce
Copy link
Contributor

Also, shouldn't the icons be aligned to the left?

@javierarce
Copy link
Contributor

I found this issue is pretty similar to this older one: Search Block: Button options needs indicator which option is active. #27330.

@karmatosed's solution here, makes sense to me… so maybe we should close this issue?

@priethor
Copy link
Contributor

I agree @javierarce, let's close it as duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Search Affects the Search Block - used to display a search field [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants