Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Global Styles - allow modifying alignment widths #30761

Closed
Sandstromer opened this issue Apr 12, 2021 · 5 comments
Closed

Feature request: Global Styles - allow modifying alignment widths #30761

Sandstromer opened this issue Apr 12, 2021 · 5 comments
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.

Comments

@Sandstromer
Copy link

What problem does this address?

In FSE global styles, it is possible to edit the typography and colors but some styles such as alignments are not available for editing.

What is your proposed solution?

Open up global styles editing to more styles such as alignments, for example in TT1-Blocks theme, contentSize is 610px and wideSize is 1240px.

Users should be able to change these alignment widths.

@Sandstromer Sandstromer changed the title Global Styles - allow more styles to be changed Feature request: Global Styles - allow more styles to be changed Apr 19, 2021
@skorasaurus
Copy link
Member

Does #29506 cover what you're looking for?

@skorasaurus skorasaurus added the [Status] Needs More Info Follow-up required in order to be actionable. label Apr 21, 2021
@Sandstromer
Copy link
Author

I think "Allow modifying the default values in Global Styles -> Spacing." does yes.

@skorasaurus
Copy link
Member

skorasaurus commented Apr 23, 2021

thanks, could you edit your title to reflect that so it's easier to find?

@skorasaurus skorasaurus added Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement. and removed [Status] Needs More Info Follow-up required in order to be actionable. labels Apr 23, 2021
@skorasaurus skorasaurus mentioned this issue Apr 23, 2021
12 tasks
@Sandstromer Sandstromer changed the title Feature request: Global Styles - allow more styles to be changed Feature request: Global Styles - allow modifying alignment widths Apr 24, 2021
@carolinan
Copy link
Contributor

carolinan commented Sep 12, 2022

The ability to change the content width and wide width values is already possible under the layout panel in the styles
sidebar ( so only for themes that support the global styles)

@skorasaurus
Copy link
Member

This has been implemented for a while in theme.json

e.g.

"layout": {
      "contentSize": "75 vw",
      "wideSize": "85 vw"
    },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants