Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Block: Quote #311

Closed
mtias opened this issue Mar 23, 2017 · 7 comments
Closed

Add Block: Quote #311

mtias opened this issue Mar 23, 2017 · 7 comments
Assignees
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@mtias
Copy link
Member

mtias commented Mar 23, 2017

Attributes

  • Alignment: None, Left, Right, Center, Full Bleed.
  • Alternative style of quote.
  • Cite (fixed field).

Markup

<!-- wp:quote -->
<blockquote>
    <p>The quick brown fox jumps over the lazy dog.</p>
    <cite>Author</cite>
</blockquote>
<!-- /wp -->

States (see all)

image

image

@mtias mtias added Framework Issues related to broader framework topics, especially as it relates to javascript [Type] Task Issues or PRs that have been broken down into an individual action to take labels Mar 23, 2017
@BE-Webdesign
Copy link
Contributor

Going to try to do a PR for this.

@ellatrix
Copy link
Member

Can blockquotes have things like headings and lists? If so, how can they be added and changed?

@joyously
Copy link

Can blockquotes have things like headings and lists?

Yes, HTML is fairly liberal about nesting. Since a blockquote is an extended quotation, it can have lots of different HTML elements that are flow content.

And did you know that there is a cite attribute for the blockquote element? It is distinct from a separate cite element.

@ellatrix
Copy link
Member

@joyously I know it's possible in HTML and the current editor. Asking about this particular block. I think that some blocks might need to act as "container blocks". Blockquote is a good example, and there are plenty of sites that have stuff like an aside/explainer.

@joyously
Copy link

I was talking about this particular block also. It's similar to what I commented on the Text block: "do you parse it as they edit and make it into other blocks or let them put whatever they want?".
As stated, the markup for this block can contain other HTML elements. But the <p> tags cannot. I think those should be removed.

@mtias
Copy link
Member Author

mtias commented Mar 27, 2017

In my research, markup for quotes is not trivial. Some use <footer> instead of cite, for instance.

Also keep in mind the second style of block is similar to the purpose of the quote post-format. Interestingly, shortcake shows a very similar example where the need for a separate source attribute is clearer.

@youknowriad
Copy link
Contributor

Closing this. All quote features are there I think. And we can open specific issues anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

No branches or pull requests

6 participants