Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typedefs for core/navigation-link block attributes #31450

Open
getdave opened this issue May 4, 2021 · 0 comments
Open

Add typedefs for core/navigation-link block attributes #31450

getdave opened this issue May 4, 2021 · 0 comments
Labels
[Block] Navigation Affects the Navigation Block [Type] Enhancement A suggestion for improvement.

Comments

@getdave
Copy link
Contributor

getdave commented May 4, 2021

Let's add typedefs for the core/navigation-link block attributes and share these with the navigation editor. This will make it easier to understand the various fields and what they do and also how these map to nav_menu_item's.


Also optional, since we can always follow up later, but a typedef also works well for any enums we need to define:

https://developer.wordpress.org/block-editor/contributors/code/coding-guidelines/#custom-types

Originally posted by @gwwar in #31004 (comment)

@skorasaurus skorasaurus added the [Block] Post Navigation Link Affects the Post Navigation Link Block label May 5, 2021
@ntsekouras ntsekouras added [Block] Navigation Affects the Navigation Block and removed [Block] Post Navigation Link Affects the Post Navigation Link Block labels Aug 4, 2021
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants