Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Family: make it work like any other block support with presets #31489

Closed
oandregal opened this issue May 5, 2021 · 3 comments · Fixed by #31910
Closed

Font Family: make it work like any other block support with presets #31489

oandregal opened this issue May 5, 2021 · 3 comments · Fixed by #31910
Assignees
Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. [Status] In Progress Tracking issues with work in progress

Comments

@oandregal
Copy link
Member

The block supports mechanism works by attaching classes (when the property has preset values such as colors or font-sizes) or inline styles (when it doesn't such as line-height or when the user selects custom values for colors or font-sizes).

The link color was an exception to this model because it addresses the inner markup of a block. We experimented with using CSS Custom Properties for that one but that approach had some issues and we're now exploring an alternative at #31488

The font family also uses CSS Custom Properties but there's no reason it shouldn't work like the rest of the block supports with presets. We should make it work like the rest in preparation for stabilizing it #31416 (comment)

@oandregal oandregal mentioned this issue May 5, 2021
82 tasks
@paaljoachim paaljoachim added the CSS Styling Related to editor and front end styles, CSS-specific issues. label May 6, 2021
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label May 17, 2021
@youknowriad
Copy link
Contributor

I think this one is still experimental right? So we can remove it from the 5.8 must haves?

@oandregal
Copy link
Member Author

Yes, forgot about the board (had already triaged it at #20331).

@ockham
Copy link
Contributor

ockham commented May 31, 2021

(Some WIP here: #31910)

@oandregal oandregal assigned oandregal and unassigned ockham Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. [Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants