You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
These do (almost!) exactly the same thing but differ in their implementation.
What is your proposed solution?
I am proposing that we unify under a single well-tested implementation. Once the implementation is in place, we can (for now) then duplicate it between block and editor.
Note I would do this in the PR that proposes the package, but it would cause the PR to become overly complex and large. I'd prefer to refactor in isolation from the package PR and then rebase that PR when we are confident we have a stable implementation across both codebases.
The text was updated successfully, but these errors were encountered:
What problem does this address?
Currently we have two locations within the codebase that convert WP Nav Menu items into
core/navigation-link
blocks:These do (almost!) exactly the same thing but differ in their implementation.
What is your proposed solution?
I am proposing that we unify under a single well-tested implementation. Once the implementation is in place, we can (for now) then duplicate it between block and editor.
In the longer term, we can then remove the duplication by (hopefully) placing the conversion code into the proposed
@wordpress/menus
package.Note I would do this in the PR that proposes the package, but it would cause the PR to become overly complex and large. I'd prefer to refactor in isolation from the package PR and then rebase that PR when we are confident we have a stable implementation across both codebases.
The text was updated successfully, but these errors were encountered: