Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post author field: when search is enabled, it shows some wrong results #32127

Closed
luis-movel opened this issue May 22, 2021 · 5 comments · Fixed by #32344
Closed

Post author field: when search is enabled, it shows some wrong results #32127

luis-movel opened this issue May 22, 2021 · 5 comments · Fixed by #32344
Assignees
Labels
[Package] Editor /packages/editor [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@luis-movel
Copy link

Description

Issue 1: Author search field don't show the right results (properly retrieved by the API) on the top of the list.
Issue 2: When you scroll down to the end of this list, you can see the results, but you can't select them.

It may have some relation with this pull request: #5921

Step-by-step reproduction instructions

  1. Create more than 1000 different users, to make sure the post author field becomes a text field (not select).
  2. Choose a post to edit and try to change the author of this post, by typing a name.
  3. Check that the first given names are not the names you're looking for (issue 1).
  4. Scroll down the list until you see the right names and try to select them (issue 2).

Expected behaviour

By typing the name of the user you're looking for, the first results would be the users retrieved by the API and you can select them.

Actual behaviour

By typing the name of the user you're looking for, the first results are not the users retrieved by the API. If you scroll down to the bottom of the list, you can find the results of the search, but, you can't select them - it kind of "jump" to the begining of the list when you hover them (as shown in the screen recording below).

It only happens when the author field is a text field, not select (as far as I realized, this field is shown when there's more than 1000 users in the list).

Screenshots or screen recording (optional)

image

Editar post ‹ Blog — WordPress - Mozilla Firefox 2021-05-22 17-11-49

WordPress information

WordPress version: 5.7.2 (also happening with previous versions)
Gutenberg version: N/A
Are all plugins except Gutenberg deactivated? Yes - I made some tests with all plugins deactivated - it still happens.
Are you using a default theme (e.g. Twenty Twenty-One)? Yes

Device information

Device: Desktop
Operating system: Windows 10
Browser: Tested on Chrome and Firefox.

@Mamaduka Mamaduka added [Package] Editor /packages/editor Needs Testing Needs further testing to be confirmed. labels May 24, 2021
@Mamaduka
Copy link
Member

Hi, @luis-movel

I wasn't able to reproduce the issue, but I've my guess why this might happen.

Just to confirm: Do you see any errors in DevTool's console? You might want to enable SCRIPT_DEBUG for React to display errors.

@luis-movel
Copy link
Author

Hi, @Mamaduka! Thank you for the reply.

I've just enabled SCRIPT DEBUG and it displays errors like this when I click at the post author field:

image

It repeats for some different users.

Might it be related to the issue?

Thanks!

@Mamaduka
Copy link
Member

Thanks for the confirmation, @luis-movel.

@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended and removed Needs Testing Needs further testing to be confirmed. labels May 28, 2021
@luis-movel
Copy link
Author

No problem, @Mamaduka !

If you need some more tests, just let me know.

Thank you!

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label May 31, 2021
@Mamaduka
Copy link
Member

Mamaduka commented Jun 2, 2021

@luis-movel I just merged the fix for this issue, and it should be part of 10.8 release.

Feel free to reopen the issue if you still experience the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Editor /packages/editor [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants