Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar overflows viewport on small right aligned images #32402

Closed
Azragh opened this issue Jun 2, 2021 · 4 comments · Fixed by #35082
Closed

Toolbar overflows viewport on small right aligned images #32402

Azragh opened this issue Jun 2, 2021 · 4 comments · Fixed by #35082
Labels
[Block] Image Affects the Image Block [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended

Comments

@Azragh
Copy link

Azragh commented Jun 2, 2021

Description

Toolbar overflows viewport on small right aligned images. Not much more to say here.

Step-by-step reproduction instructions

Create an image block, choose alignright and resize it to 150px or so. In Twenty Twenty-One you maybe have to resize the browser a little bit to see this behaviour.

Screenshots

image

WordPress information

  • WordPress version: 5.7.2
  • Gutenberg version: 10.7.1

Only Gutenberg active with Twenty Twenty-One

Device information

  • Device: Desktop
  • Operating system: Windows
  • Browser: Chrome
@Mamaduka Mamaduka added the [Block] Image Affects the Image Block label Jun 9, 2021
@simison simison added the [Type] Bug An existing feature does not function as intended label Jun 15, 2021
@inaikem
Copy link

inaikem commented Jul 19, 2021

Replicated while scrubbing a related bug elsewhere. Please note that the issue is present in many, if not all instances where the toolbar appears over an element towards the right of the main editor window.

This example shows a toolbar appearing over an image block in the right-most column of a column block:

Tooblar hidden

@talldan
Copy link
Contributor

talldan commented Jul 21, 2021

This was flagged on the forums, and when testing it definitely seems to happen, especially in a right-hand column:
Screenshot 2021-07-21 at 5 41 48 pm

Feels like a possible regression and a definite usability issue. Raising the priority.

@antonyjsmith
Copy link

Thanks @talldan. To clarify, this has been around for some time, it's not emerged with 5.8. I'd just wearily come to accept it, however it's getting increasingly worse as the popover continues to grow.

@youknowriad youknowriad added this to the WordPress 5.8.1 milestone Jul 23, 2021
@youknowriad
Copy link
Contributor

I do recall that we fixed this in the past with some popover shifting behavior, it might have regressed cc @ellatrix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Image Affects the Image Block [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants