-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reusable block: Replace "Convert to regular blocks" icon #32586
Comments
@paaljoachim How about this icon? I have searched about the icons and I found this with correct meaning (I Guess). |
Hi @malavvasita Malav Yeah. Something like that conveys the conversion meaning. |
I just asked in the Slack accessibility channel. Regarding icon vs text. I just needed some obvious feedback. I believe it might be most helpful if we just switched the current icon back to a word. Going from this: To: @jasmussen Any additional thoughts? Thanks! |
The icon here is intentional to make sure the block toolbar scales to mobile devices. German adds 20% of width to text labels, and when showing the title of the block we have to accommodate that. So it's an intentional tradeoff that converting the reusable block needs less prominence than the reusable block title. In light of separate discussions about locking the content and adding high friction to editing reusable blocks, the current balance seems right to me, even if we can continue to explore a better icon. Also keep in mind we have this in the overflow menu: |
FWIW, in the site I am testing one, I do not have the option "Convert to regular blocks" in my overflow menu. I only have the icon in the main toolbar. that people are discussing. Also, FWIW, since I don't see the option in the overflow menu, and I assumed that the icon meant Personally I don't see why converting to regular blocks is such a prominent thing in the tool bar. |
Hi @thesunshade
The "Convert to regular blocks" in the overflow menu can be seen when activating the Gutenberg plugin.
The icon does look like a copy icon. Example searching for copy icon brings up this search: https://www.ecosia.org/images?q=copy%20icon What we are hoping with this issue is to change the icon to something that would hopefully remind people about a conversion/convert process.
It gives a quick reminder that one can convert a Reusable block into regular blocks. As modifying the Reusable block will affect all other instances/places the same Reusable block is used. Having the icon prominent in place in the toolbar will hopefully remind people that they need to convert to regular blocks before interacting with the Reusable block. Thank you for your comments! |
What problem does this address?
The following "Convert to regular blocks" icon does not convey the symbolic meaning of convert.
It looks more like an icon that will duplicate.
What is your proposed solution?
We need to switch out the icon with another symbol that conveys the convert action, or perhaps instead add the word convert.
Suggestion 1. I did a search for a Convert icon and noticed this (somewhat similar to the plugin update icon though) I went ahead and added the icon to the toolbar (to just show another icon that portrays another meaning). It does need a totally new icon that gives a convert meaning.
Suggestion 2. Adding in the word "Convert" instead.
The text was updated successfully, but these errors were encountered: