Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reusable block: Replace "Convert to regular blocks" icon #32586

Closed
paaljoachim opened this issue Jun 10, 2021 · 8 comments
Closed

Reusable block: Replace "Convert to regular blocks" icon #32586

paaljoachim opened this issue Jun 10, 2021 · 8 comments
Labels
[Block] Block The "Reusable Block" Block [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@paaljoachim
Copy link
Contributor

paaljoachim commented Jun 10, 2021

What problem does this address?

The following "Convert to regular blocks" icon does not convey the symbolic meaning of convert.
It looks more like an icon that will duplicate.

Screen Shot 2021-06-10 at 15 15 56

What is your proposed solution?

We need to switch out the icon with another symbol that conveys the convert action, or perhaps instead add the word convert.

Suggestion 1. I did a search for a Convert icon and noticed this (somewhat similar to the plugin update icon though) I went ahead and added the icon to the toolbar (to just show another icon that portrays another meaning). It does need a totally new icon that gives a convert meaning.
Reusable-block-convert-icon

Suggestion 2. Adding in the word "Convert" instead.

Reusable-blocks-Convert-Text

@paaljoachim paaljoachim added [Block] Block The "Reusable Block" Block [Type] Enhancement A suggestion for improvement. labels Jun 10, 2021
@paaljoachim paaljoachim changed the title Reusable block: Replace "convert icon to regular blocks" icon Reusable block: Replace "Convert to regular blocks" icon Jun 10, 2021
@paaljoachim paaljoachim added [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) Needs Design Feedback Needs general design feedback. labels Jun 10, 2021
@malavvasita
Copy link

@paaljoachim How about this icon?

I have searched about the icons and I found this with correct meaning (I Guess).

Convert to regular blocks

@paaljoachim
Copy link
Contributor Author

Hi @malavvasita Malav

Yeah. Something like that conveys the conversion meaning.
We will see what @keoshi Filipe can come up with as well..:)
Thank you for adding the suggestion!

@paaljoachim
Copy link
Contributor Author

paaljoachim commented Jun 15, 2021

I went ahead and adjusted the icon in your suggestion, Malav.
It might be too detailed, but I am thinking about a more detailed visual going from one Reusable block and converting it back into (might be) multiple blocks. (It is not there yet.)

Reusable-block-new-convert-icon

@paaljoachim
Copy link
Contributor Author

paaljoachim commented Jun 23, 2021

I just asked in the Slack accessibility channel. Regarding icon vs text. I just needed some obvious feedback.
As text says right there what is being done. One does not need to guess. Having an icon that is not a common icon the user has to make a guess the meaning of the icon. In addition WP 5.6.2 a Reusable block toolbar looked like this:

Screen Shot 2021-06-23 at 06 59 32

I believe it might be most helpful if we just switched the current icon back to a word.

Going from this:

Screen Shot 2021-06-23 at 07 05 31

To:

Convert-with-a-word

@jasmussen Any additional thoughts?

Thanks!

@jasmussen
Copy link
Contributor

The icon here is intentional to make sure the block toolbar scales to mobile devices. German adds 20% of width to text labels, and when showing the title of the block we have to accommodate that. So it's an intentional tradeoff that converting the reusable block needs less prominence than the reusable block title. In light of separate discussions about locking the content and adding high friction to editing reusable blocks, the current balance seems right to me, even if we can continue to explore a better icon.

Also keep in mind we have this in the overflow menu:

Screenshot 2021-06-23 at 08 46 34

@thesunshade
Copy link

Also keep in mind we have this in the overflow menu:

FWIW, in the site I am testing one, I do not have the option "Convert to regular blocks" in my overflow menu. I only have the icon in the main toolbar. that people are discussing.

Also, FWIW, since I don't see the option in the overflow menu, and I assumed that the icon meant copy, I thought that this feature had somehow been removed!

Personally I don't see why converting to regular blocks is such a prominent thing in the tool bar.

@paaljoachim
Copy link
Contributor Author

Hi @thesunshade

FWIW, in the site I am testing one, I do not have the option "Convert to regular blocks" in my overflow menu. I only have the icon in the main toolbar. that people are discussing.

The "Convert to regular blocks" in the overflow menu can be seen when activating the Gutenberg plugin.

Also, FWIW, since I don't see the option in the overflow menu, and I assumed that the icon meant copy, I thought that this feature had somehow been removed!

The icon does look like a copy icon. Example searching for copy icon brings up this search: https://www.ecosia.org/images?q=copy%20icon

What we are hoping with this issue is to change the icon to something that would hopefully remind people about a conversion/convert process.

Personally I don't see why converting to regular blocks is such a prominent thing in the tool bar.

It gives a quick reminder that one can convert a Reusable block into regular blocks. As modifying the Reusable block will affect all other instances/places the same Reusable block is used. Having the icon prominent in place in the toolbar will hopefully remind people that they need to convert to regular blocks before interacting with the Reusable block.

Thank you for your comments!

@jordesign
Copy link
Contributor

Closing this issue as the interface is now changed - to use the 'Detach Pattern' terminology.

Screenshot 2023-10-30 at 5 33 43 pm

@jordesign jordesign closed this as not planned Won't fix, can't repro, duplicate, stale Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Block The "Reusable Block" Block [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

5 participants