isScrollable prop in CardBody component is causing a visual glitch in pre-existing components without isScrollable prop.

[moon0326]

Description

The latest Gutenberg (11.0) causes a visual glitch on WooCommerce onboarding wizard pages where Card component is being used.

It looks like isScrollable has been added recently and the default value is set to true. I think the default value should be false to prevent any backward compatibility issues.

Step-by-step reproduction instructions

1. Deactivate plugins except for Gutenberg and WooCommerce
2. Navigate to WooCommerce -> Home to trigger the onboarding wizard.
3. Click the country dropdown and confirm the unexpected scrollbar.
4. Deactivate Gutenberg and repeat the same step. Confirm there is no scrollbar for this time.

Expected behaviour

The scrollbar should not appear.

Actual behaviour

Unexpected scrollbar appears where Card component is being used.

Screenshots or screen recording (optional)

WordPress information

• WordPress version: 5.7.2
• Gutenberg version: 11.0.0
• Are all plugins except Gutenberg deactivated? No (WooCommerce is activated)
• Are you using a default theme (e.g. Twenty Twenty-One)? Yes

Device information

• Device: Desktop
• Operating system: Mac OS BigSur
• Browser: Chrome 91.0.4472.114

[moon0326]

WC Admin team is working on a fix for wordpress.com customers in this PR

[talldan]

@moon0326 Do you know which PR caused the issue?

[moon0326]

@talldan I think this PR caused the issue.

[talldan]

Thanks @moon0326.

@ciampo Is this something you'd have time to take a look at?

[ciampo]

Thank you @talldan for the ping — I opened (update: and merged) #33490 which changes the default value of isScrollable to false.

Once that PR gets included in the next Gutenberg release, it'd be great if we could revert the hotfix, since it looks quite hacky — @moon0326 , would you be able to track this task on your side?

[moon0326]

Thank you @talldan for the ping — I opened (update: and merged) #33490 which changes the default value of isScrollable to false.

Once that PR gets included in the next Gutenberg release, it'd be great if we could revert the hotfix, since it looks quite hacky — @moon0326 , would you be able to track this task on your side?

Thank you @ciampo for the PR 🙇 I'll track the task on my side.

It looks like the next release date is July 28, 2011, according to https://github.com/WordPress/gutenberg/milestones.

I'm setting a reminder to check it back on July 29, 2021. I'll work on a PR to revert back my change once I confirm the change in the new version.

[talldan]

Closing this as it seems like the issue has been fixed in this repo.