Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Widget Screen] Adding blocks to columns from 'Browse All' does not work as expected #33658

Closed
sajmes opened this issue Jul 23, 2021 · 2 comments
Labels
[Feature] Widgets Customizer Ability to add and edit blocks in Customize → Widgets. [Feature] Widgets Screen The block-based screen that replaced widgets.php. [Package] Edit Widgets /packages/edit-widgets [Type] Bug An existing feature does not function as intended

Comments

@sajmes
Copy link

sajmes commented Jul 23, 2021

Description

When adding a columns block in the widgets editor, adding blocks to the columns from 'browse all' does not behave as expected/how adding blocks to a column works in the regular editor. A block added from 'browse all' does not get added to the intended destination column where + was clicked. Instead it is added below the column block.

Adding blocks from the options presented in the initial block picker does work as expected.

Additionally, the search feature does not work in 'browse all' unless you first search and then clear that search before searching again OR click somewhere outside the search field within 'browse all' to reveal all available blocks before searching.

Step-by-step reproduction instructions

Expected behaviour

I expect that when clicking + in a column and clicking 'browse all' I will see a list of available blocks and can click a block in that area to add it to the destination column where + was clicked.

I expect that searching from 'browse all' will show all blocks that match my search criteria.

Actual behaviour

When clicking + in a column within a column block and then clicking 'browse all', I see only the column block in the 'browse all' area that slides out. I cannot see the available blocks until I click somewhere in the 'browse all' area.

Once available blocks are revealed, clicking a block does not add it to the destination column where + was clicked. Instead, it adds it below the column block as a new independent block.

When clicking search in 'browse all' without having first clicked elsewhere in 'browse all', the search returns no results.

Screenshots or screen recording (optional)

Screen Capture on 2021-07-22 at 11-46-26

WordPress information

  • WordPress version: 5.8
  • Gutenberg version: 11.0.0
  • Are all plugins except Gutenberg deactivated? Yes
  • Are you using a default theme (e.g. Twenty Twenty-One)? Yes - Twenty Twenty

Device information

  • Device: M1 Macbook Pro
  • Operating system: macOS 11.4
  • Browser: Chrome 91.0.4472.114
@Mamaduka Mamaduka added [Feature] Widgets Customizer Ability to add and edit blocks in Customize → Widgets. Needs Testing Needs further testing to be confirmed. labels Jul 26, 2021
@draganescu draganescu added [Type] Bug An existing feature does not function as intended [Feature] Widgets Screen The block-based screen that replaced widgets.php. [Package] Edit Widgets /packages/edit-widgets and removed Needs Testing Needs further testing to be confirmed. labels Jul 26, 2021
@draganescu
Copy link
Contributor

I tested and can confirm this broken behavior.

@kevin940726
Copy link
Member

I believe this was fixed in #33802. Here's the screencast I just recorded in trunk.

Kapture.2021-08-04.at.12.39.14.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Widgets Customizer Ability to add and edit blocks in Customize → Widgets. [Feature] Widgets Screen The block-based screen that replaced widgets.php. [Package] Edit Widgets /packages/edit-widgets [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants