Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve how different types of nav items are rendered on the Navigation screen #34035

Closed
Tracked by #29102
javierarce opened this issue Aug 12, 2021 · 4 comments
Closed
Tracked by #29102
Labels
Needs Design Needs design efforts.

Comments

@javierarce
Copy link
Contributor

The current design of the menu items is quite messy right now. For simple menus, it's probably fine… but when there are different items and empty states, the interface becomes cluttered.

Here's an extreme example:

image

Some of the things that would improve how menus look like could be:

  • Unifying the look of the placeholders.
  • Improving the spacing.
  • Improving the design of the page list.
@javierarce
Copy link
Contributor Author

javierarce commented Aug 12, 2021

@getdave getdave changed the title Navigation screen: improve how different types of items are rendered Improve how different types of nav items are rendered on the Navigation screen Aug 25, 2021
@talldan
Copy link
Contributor

talldan commented Sep 17, 2021

This should be improved quite a bit now with some recent styling fixes. I think the only things that's the same as the screenshot are the item placeholders.

@javierarce Would you be able to look at the latest version in trunk to see if there's anything you think can be improved?

@karmatosed
Copy link
Member

For context here is what it currently looks like:

2021-09-17 at 16 45

2021-09-17 at 16 48

The edges certainly are easier in these examples.

My only issue is how the drop-down auto-closes that feels a little awkward when I might want to see within, but that probably doesn't need to be in MVP. There is also an issue already around the squiggles: #34780

@javierarce
Copy link
Contributor Author

I'm closing this issue since the navigation screen is no longer actively developed.

Related: #43620.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Needs design efforts.
Projects
None yet
Development

No branches or pull requests

3 participants