Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block toolbar is cropped when the block is toward the right side of the screen #34053

Closed
3 tasks done
jasmussen opened this issue Aug 12, 2021 · 5 comments · Fixed by #35082
Closed
3 tasks done

Block toolbar is cropped when the block is toward the right side of the screen #34053

jasmussen opened this issue Aug 12, 2021 · 5 comments · Fixed by #35082
Assignees
Labels
[Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release

Comments

@jasmussen
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Have you tried deactivating all plugins except Gutenberg?

  • I have tested with all plugins deactivated.

Have you tried replicating the bug using a default theme e.g. Twenty Twenty?

  • I have tested with a default theme.

Description

The block toolbar should be able to bump against screen edges to never be cropped like it is if you insert a block inside a right-most column:

Screenshot 2021-08-12 at 22 46 26

This used to work, but appears to have regressed at some point.

Step-by-step reproduction instructions

  1. Insert a columns block.
  2. Insert a block with a wide toolbar inside the right most column, and select it.
  3. Narrow the viewport so the toolbar gets cropped.

Expected Behavior

The block toolbar should never be cropped, and should bump against screen edges, and in this case be pushed leftwards by the right screen edge.

Current Behavior

It's cropped.

Screenshots or screen recording (optional)

No response

Code snippet (optional)

No response

WordPress Information

No response

Gutenberg Information

No response

What browsers are you seeing the problem on?

No response

Device Information

No response

Operating System Information

No response

@jasmussen jasmussen changed the title <title> Block toolbar is cropped when the block is toward the right side of the screen Aug 12, 2021
@jasmussen jasmussen added [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release labels Aug 12, 2021
@jasmussen
Copy link
Contributor Author

I could swear this used to work. @ellatrix do you recall?

@annezazu
Copy link
Contributor

Wondering if this might be related to this phenomenon too: #30398

@jasmussen
Copy link
Contributor Author

Yes, that appears related. The block toolbar should always bump against screen edges.

@ellatrix
Copy link
Member

I could swear this used to work. @ellatrix do you recall?

Yes, we fixed this in the G2 PR #19344. That's what the __unstableBoundaryParent is for. Must have regressed somewhere. I can have a look.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Sep 23, 2021
@jasmussen
Copy link
Contributor Author

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants