Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only enqueue default colors & gradients once #34138

Closed
oandregal opened this issue Aug 18, 2021 · 1 comment · Fixed by #34510
Closed

Only enqueue default colors & gradients once #34138

oandregal opened this issue Aug 18, 2021 · 1 comment · Fixed by #34510
Assignees
@oandregal
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Package] Block editor /packages/block-editor [Package] Block library /packages/block-library [Status] In Progress Tracking issues with work in progress

Comments

@oandregal
Copy link
Member

oandregal commented Aug 18, 2021 •
edited
Loading

Related #34006

We're now currently shipping CSS bundled via the JavaScript packages that are enqueued by the global stylesheet as well. We need to consolidate this for all the use cases we have: themes with and without theme.json whether or not they declare a custom palette and gradients.

This was tried at #33924 and had to be reverted at #34108 The PR was reverted because themes that don't have a theme.json and don't provide a color palette either still need the CSS that is currently provided by the block-library. There was an attempt to fix that at #34067 but it turned out to be more complex than anticipated, so we bailed from that approach to look for a simpler alternative.
@oandregal oandregal added [Package] Block library /packages/block-library [Package] Block editor /packages/block-editor Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Aug 18, 2021
@oandregal oandregal changed the title Remove default colors & gradients from the block-library bundle Only enqueue default colors & gradients once Aug 18, 2021
This was referenced Aug 18, 2021
Closed
Closed
@oandregal oandregal mentioned this issue Aug 26, 2021
Closed
@oandregal oandregal mentioned this issue Sep 2, 2021
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Sep 2, 2021
@oandregal
Copy link
Member Author

Second try at #34510

This was referenced Sep 28, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oandregal oandregal

Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Package] Block editor /packages/block-editor [Package] Block library /packages/block-library [Status] In Progress Tracking issues with work in progress
Projects
None yet
Milestone
No milestone
1 participant
@oandregal